The regexp used for excluding vcs directories aren't correct for code_sniffer.

On coder_sniffer/Drupal/ruleset.xml we use the following pattern:
<exclude-pattern>*/.hg/*</exclude-pattern>

sadly, one internal project is know as "lhg" and so match the exclude pattern because dot is a wildcard.

I advice to escape this so dot can be only a dot when excluding patterns.

I have attached the patch to fix this issue.

CommentFileSizeAuthor
#2 2553021.patch704 bytesvimar

Comments

vimar created an issue. See original summary.

vimar’s picture

Issue summary: View changes
StatusFileSize
new704 bytes

  • klausi committed dc5a5f0 on 7.x-2.x authored by vimar
    Issue #2553021 by vimar: Exclude patterns for VCS directories are...
klausi’s picture

Version: 7.x-2.x-dev » 8.x-2.x-dev
Status: Active » Fixed

Good point, committed, thanks!

  • klausi committed 2dc5654 on 8.x-2.x authored by vimar
    Issue #2553021 by vimar: Exclude patterns for VCS directories are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.