I just want to do a small amounts of housekeeping as I go

I could create an issue to do this throughout the module, but I would rather keep the maintenance and review burden to small bite sized chunks

So I am just going to convert the calls to t() to a small localized area.

Plugin/Flag all the FlagTypes need converting.

All the FlagTypes need string translation at the moment, so it seems an appropriate thing to add the the FlagTypeBase class.

CommentFileSizeAuthor
#2 translate-2552169-2.patch9.17 KBmartin107

Comments

martin107 created an issue. See original summary.

martin107’s picture

Assigned: martin107 » Unassigned
Status: Active » Needs review
StatusFileSize
new9.17 KB

Status: Needs review » Needs work

The last submitted patch, 2: translate-2552169-2.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: translate-2552169-2.patch, failed testing.

martin107’s picture

Status: Needs work » Closed (works as designed)

After reading

http://drupal.stackexchange.com/questions/83174/what-is-the-difference-b...

it looks best to keep using tl() over $this->t()

For me that is useful information ... in years to come over the lifecycle of 8.0.x t() will persist in a small set of places.