See meta-issue: #2511554: [meta] Move some parts of Page Manager into CTools and #2511560: Add Drupal\page_manager\Plugin\VariantAwareInterface and VariantCollection from Page Manager

Per the ctools issue:

  1. Move VariantAwareInterface (and related tests) into CTools and rename to VariantCollectionInterface
  2. Create a Page Manager issue for refactoring the code to use this interface
  3. Do manual testing that Page Manager still works
  4. Make sure automated tests in both CTools and Page Manager pass
CommentFileSizeAuthor
#10 2550959-move-VariantCollection-10.patch12.02 KBsaltednut
#9 2550959-move-VariantCollection-9.patch12.24 KBsaltednut
#5 2550959-move-VariantCollection-5.patch12.24 KBsaltednut
#3 2550959-remove-VariantAwareInterface-3.patch11.08 KBsaltednut
#2 2550959-remove-VariantAwareInterface-1.patch10.86 KBsaltednut
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

brantwynn created an issue. See original summary.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
FileSize
2550959-remove-VariantAwareInterface-1.patch10.86 KB

Initial pass at the removal and refactoring of usage. This will also result in ctools becoming a dependency to of page_manager.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
Status: Active » Needs review
FileSize
2550959-remove-VariantAwareInterface-3.patch11.08 KB

Added dependency to ctools.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
Title: Remove VariantAwareInterface, ctools to provide VariantCollectionInterface instead » Remove VariantAwareInterface, ctools to provide VariantCollection and VariantCollectionInterface instead
saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
FileSize
2550959-move-VariantCollection-5.patch12.24 KB

This patch removes VariantCollection, VariantAwareInterface and VariantAwareTrait plus related tests.

Those components will be moved to ctools as follows.

\Drupal\page_manager\Plugin\VariantCollection -> \Drupal\ctools\Plugin\VariantCollection

\Drupal\page_manager\Plugin\VariantAwareInterface -> \Drupal\ctools\Plugin\VariantCollectionInterface

\Drupal\page_manager\Plugin\VariantAwareTrait -> \Drupal\ctools\Plugin\VariantCollectionTrait

Also see: #2511560-8: Add Drupal\page_manager\Plugin\VariantAwareInterface and VariantCollection from Page Manager

The last submitted patch, 3: 2550959-remove-VariantAwareInterface-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: 2550959-move-VariantCollection-5.patch, failed testing.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
Status: Needs work » Postponed

Postponed by #2551195: Add dependency on CTools and #2511560: Add Drupal\page_manager\Plugin\VariantAwareInterface and VariantCollection from Page Manager

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
FileSize
2550959-move-VariantCollection-9.patch12.24 KB

Updating patch as #2551195: Add dependency on CTools has landed.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
CreditAttribution: saltednut at Acquia commented
FileSize
2550959-move-VariantCollection-10.patch12.02 KB

Sorry, the last patch did not have the correct upstream merge. This one does not touch the .info.yml file.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
CreditAttribution: dsnopek commented
Status: Postponed » Closed (duplicate)

This was fixed in some other issue that I can't seem to track down now. But those classes are removed in any case!