There's a reference to the non-existent node_menu in src/Controller/NodeController.php in the function addPage(). The function is now called from node.routing.yml, instead. This inconstancy adds confusion when reading through the code.

CommentFileSizeAuthor
#2 drupal-replace_node_menu_reference-2550579.patch564 bytesjeremy

Comments

Jeremy created an issue. See original summary.

jeremy’s picture

jeremy commented
Status: Active » Needs review
StatusFileSize
new drupal-replace_node_menu_reference-2550579.patch564 bytes

This is a trivial change from @see node_menu to @see node.routing.yml -- no CR as it doesn't affect anything but internal documentation.

monika.kadam1206’s picture

monika.kadam1206 commented
Assigned: Unassigned » monika.kadam1206
monika.kadam1206’s picture

monika.kadam1206 commented
Assigned: monika.kadam1206 » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks Good!!!

Nothing affect internally but helps for code walk through.

Was a trifling change to @see node_menu to @see node.routing.yml

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: drupal-replace_node_menu_reference-2550579.patch, failed testing.

The last submitted patch, 2: drupal-replace_node_menu_reference-2550579.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

anish.a’s picture

anish.a commented
Version: 8.2.x-dev » 8.3.x-dev
Status: Needs work » Fixed

The issue is fixed in 8.3.x

The relevant code


  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container) {
    return new static(
      $container->get('date.formatter'),
      $container->get('renderer')
    );
  }

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.