It should be possible to alter the view mode being used to render a file. Right now it's not possible because we are not using entity_view_mode_prepare().

CommentFileSizeAuthor
#9 2158177-require-7-33.patch2.95 KBdave reid
#7 2158177-require-7-33.patch3.83 KBdave reid
#2 2550409-file-entity-view-mode-prepare.patch1.05 KBdave reid

Comments

Dave Reid created an issue. See original summary.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2550409-file-entity-view-mode-prepare.patch1.05 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #2 to 7.x-2.x.

  • Dave Reid committed 042b596 on 7.x-2.x 
    Issue #2550409 by Dave Reid: Fixed file entities do not support...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Ah, that explains it. It was added in Drupal 7.33: https://www.drupal.org/node/2369141

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Fixed » Active

So now the question is, do we make this behavior optional, or require Drupal 7.33+, which was released Nov 7 of last year?

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2158177-require-7-33.patch3.83 KB

I think we should just require 7.33. There are too many places we need to use entity_view_mode_prepare() that we kind of need it.

Status: Needs review » Needs work

The last submitted patch, 7: 2158177-require-7-33.patch, failed testing.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2158177-require-7-33.patch2.95 KB
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #9 to 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.