When a contributed module includes a make file, it's becoming best practice to give it the extension .make.example rather than .make. There are a number of reasons for this- especially, so that a parent distribution can override the dependencies, avoid failing builds if the dependencies can't be downloaded, and avoid errors when the parent make file is in YML format and the module make file is in traditional format.
A good explanation of this issue, with links to related issues and documentation, is here: #2466233: Rename the .make file to .make.example
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | fontawesome-2550149-1.patch | 1.4 KB | danepowell |
Comments
Comment #2
danepowell commentedComment #3
sylus commentedThanks for this! Helped me get my build to pass.
Comment #4
mkhamash commentedThis should be RTBC, since having the make file will cause all Drupal distribution trying to add this module to fail the packaging process.
Comment #6
inders commentedCommit done !
Comment #7
dtarc commentedCould this be committed to 7.x-1.x branch as well? The library in the make is no longer available at that url and so 7.x-1.x blocks drush make from running.
Comment #8
dtarc commentedComment #9
daniel.moberly commentedCan you open a new issue and submit a patch?
Comment #10
daniel.moberly commentedOh, nevermind, just noticed the version you're specifying. 7.x-1.x is no longer supported. I suggest upgrading to the latest version
Comment #11
truls1502Unassigned the user