When a contributed module includes a make file, it's becoming best practice to give it the extension .make.example rather than .make. There are a number of reasons for this- especially, so that a parent distribution can override the dependencies, avoid failing builds if the dependencies can't be downloaded, and avoid errors when the parent make file is in YML format and the module make file is in traditional format.

A good explanation of this issue, with links to related issues and documentation, is here: #2466233: Rename the .make file to .make.example

CommentFileSizeAuthor
#2 fontawesome-2550149-1.patch1.4 KBDane Powell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dane Powell created an issue. See original summary.

Dane Powell’s picture

Status: Active » Needs review
FileSize
1.4 KB
sylus’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for this! Helped me get my build to pass.

mkhamash’s picture

This should be RTBC, since having the make file will cause all Drupal distribution trying to add this module to fail the packaging process.

  • Dane Powell authored 5d47062 on 7.x-2.x
    Issue #2550149 by Dane Powell: Rename .make file to .make.example
    
inders’s picture

Assigned: Unassigned » inders
Status: Reviewed & tested by the community » Closed (fixed)

Commit done !

dtarc’s picture

Could this be committed to 7.x-1.x branch as well? The library in the make is no longer available at that url and so 7.x-1.x blocks drush make from running.

dtarc’s picture

Version: 7.x-2.x-dev » 7.x-1.x-dev
Daniel.Moberly’s picture

Can you open a new issue and submit a patch?

Daniel.Moberly’s picture

Oh, nevermind, just noticed the version you're specifying. 7.x-1.x is no longer supported. I suggest upgrading to the latest version

truls1502’s picture

Assigned: inders » Unassigned

Unassigned the user