Problem/Motivation

The schema is missing the langcode attribute and doesn't pass the schema validation, basically because the type is mapping and there is no langcode attribute.
Note: This is a really easy task for an applicant for an internship at our organization. I'd appreciate it if you wouldn't work on this unless you are the person whom I sent this issue. If it isn't solved by the end of the week, I will provide a patch myself.

Proposed resolution

Switch the google_analytics.settings type from mapping to config_object.

Remaining tasks

Change the type, provide patch, review and commit it.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 fix_schema_errors_for-2550075-2.patch445 bytespravin ajaaz

Comments

LKS90 created an issue. See original summary.

pravin ajaaz’s picture

pravin ajaaz commented
StatusFileSize
new fix_schema_errors_for-2550075-2.patch445 bytes

@LKS90: Based on your suggestion.

pravin ajaaz’s picture

pravin ajaaz commented
Status: Active » Needs review
LKS90’s picture

LKS90 commented

Note: This is a really easy task for an applicant for an internship at our organization. I'd appreciate it if you wouldn't work on this unless you are the person whom I sent this issue. If it isn't solved by the end of the week, I will provide a patch myself.

Guess I'll create another one then...

pravin ajaaz’s picture

pravin ajaaz commented

Oh sorry I didn't noticed it :(

LKS90’s picture

LKS90 commented
Status: Needs review » Reviewed & tested by the community

This should be good to go.

No worries, creating a new issue right now. Just don't solve that one :P.

pravin ajaaz’s picture

pravin ajaaz commented

Ha ha sure I won't. My apologies for this again :( I am glad to help you, If you need.

hass’s picture

hass commented

What core change has broken this? What about the langcode you posted first? What does this change - change?

LKS90’s picture

LKS90 commented

#2541800: Some config do not inherit from config_object, so locale_system_set_config_langcodes() results in schema errors

when switching from mapping to config_object, you just inherit from this very simple core data_type:

# Root of a configuration object.
config_object:
  type: mapping
  mapping:
    langcode:
      type: string
      label: 'Language code'
hass’s picture

hass commented

Does this also allow per language variables/config without changing anything further? See #2276343: Re-implement per language settings in D8

LKS90’s picture

LKS90 commented

This only makes the config variables translatable (For example Web Property ID --> Web Eigentümer ID). You are asking for separate Web Property IDs for each language locale, right?
Edit: Looking at the schema my fist assumption doesn't really make sense... I'll play around with this a bit.

hass’s picture

hass commented

You are asking for separate Web Property IDs for each language locale, right?

Yes

Translating Web Property ID makes no sense to me as the interface is translated.

  • hass committed 7baa197 on 8.x-2.x authored by Pravin Ajaaz 
    Issue #2550075 by Pravin Ajaaz: Fix schema errors for
google_analytics....
hass’s picture

hass commented
Status: Reviewed & tested by the community » Fixed

Anyone has an idea if this allows the translation of the configuration values so we can close #2276343: Re-implement per language settings in D8?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 2: fix_schema_errors_for-2550075-2.patch, failed testing.

The last submitted patch, 2: fix_schema_errors_for-2550075-2.patch, failed testing.

The last submitted patch, 2: fix_schema_errors_for-2550075-2.patch, failed testing.

The last submitted patch, 2: fix_schema_errors_for-2550075-2.patch, failed testing.

The last submitted patch, 2: fix_schema_errors_for-2550075-2.patch, failed testing.

hass’s picture

hass commented
Status: Needs work » Closed (fixed)