The Twitter Cards specs had changed to only mention twitter:image:src but now promotes use of twitter:image again. LOL.

CommentFileSizeAuthor
#11 2550001-remove-image-src-rename-update-hooks.patch3.22 KBdave reid
#5 metatag-n2550001-5.patch6.24 KBdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#2267501: Replace twitter:image with twitter:image:src

This is basically reverting #2267501: Replace twitter:image with twitter:image:src.

mgzrobles’s picture

mgzrobles commented

+1

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2539438: Plan for Metatag 7.x-1.8 release

*sigh*

This needs to be in the next release.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new metatag-n2550001-5.patch6.24 KB

This renames the meta tags and updates the configuration.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed da68c18 on 7.x-1.x 
    Issue #2550001 by DamienMcKenna: Renamed twitter:image:src back to...

  • DamienMcKenna committed da68c18 on 8.x-1.x 
    Issue #2550001 by DamienMcKenna: Renamed twitter:image:src back to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Closed (fixed) » Needs work

@DamienMcKenna: We should make metatag_update_7024() and metatag_update_7030() a no-op, and avoid unnecessary changing of records. Especially since the new updates to fix it are not guaranteed to run after the problematic update hooks, since hook_update_dependencies() was not implemented.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2550001-remove-image-src-rename-update-hooks.patch3.22 KB

Patch to remove the update hooks no longer necessary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed. Thanks Dave!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.