I noticed while working on #2541344: BlockBase subclasses should merge their cache tags/contexts with the parent's (BlockBase's) that not all methods in NodeTranslationUITest have a visbility set.

I added public as visiblity because that is the default.

CommentFileSizeAuthor
method_visiblity.patch1.67 KBborisson_
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

borisson_ created an issue. See original summary.

nicrodgers’s picture

nicrodgers
Primary language English
Location Monmouthshire, UK
CreditAttribution: nicrodgers commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly to latest 8.0x-dev and now all methods in the NodeTranslationUITest have a visibility set.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

As a test-only change and a non-disruptive coding standards fix, this issue can be considered rc eligible. Reference: https://www.drupal.org/core/d8-allowed-changes#rc

Committed and pushed to 8.0.x. Thanks!

  • xjm committed 1ba3fd4 on 8.0.x 
    Issue #2549571 by borisson_, nicrodgers: method visiblity in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.