Problem/Motivation

When we create the feature it works great on the site we created it. When we enable the feature on another site, we get this error along with a few others, all complaining about undefined indexes. The timeline shows up perfectly below the error message.

After re-saving the view, it does not complain about anything. All of the error message are gone. If I revert the view, then the errors comes back.

CommentFileSizeAuthor
#6 2549435-6.patch3.17 KBdcam
#5 2549435-5.patch3.68 KBdcam
#2 views_timelinejs-fix_undefined_indexes_when_creating_feature-2549435-2.patch3.71 KBlily.yan

Comments

lily.yan created an issue. See original summary.

lily.yan’s picture

lily.yan commented
Status: Active » Needs review
StatusFileSize
new views_timelinejs-fix_undefined_indexes_when_creating_feature-2549435-2.patch3.71 KB

The style plugin sets default options values, in options_definition. Using $this->view->style_option['X'] it does not load the default values, when the view is not in the database. You have to use style_plugin->option['X']. Attached is patch to fix.

WorldFallz’s picture

WorldFallz commented

I'm happy to make this change to fix the feature providing it doesn't adversely affect the non feature implementation. I just need to test it first. Unless some others can report it tests ok without the feature as well.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Parent issue: » #2497003: Undefined index: image_style
dcam’s picture

dcam commented
StatusFileSize
new 2549435-5.patch3.68 KB

Rerolled #2.

dcam’s picture

dcam commented
StatusFileSize
new 2549435-6.patch3.17 KB

Checking to see if the problems will be solved with $this instead of the circularly-referential $this->view->style_plugin.

  • dcam committed 2c8c67f on 7.x-1.x 
    Issue #2549435 by dcam, lily.yan: Undefined indexes when creating...
dcam’s picture

dcam commented
Status: Needs review » Fixed

Committed #6. Thanks @lily.yan!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.