Support migration via Migrate module

CommentFileSizeAuthor
#7 interdiff-2549333-3-2.txt3.75 KBtaran2l
#3 geolocation-migrate_module_support-2549333-3.patch8.9 KBtaran2l
#2 geolocation-migrate_module_support-2549333-2.patch5.89 KBtaran2l

Comments

Taran2L created an issue. See original summary.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
StatusFileSize
new geolocation-migrate_module_support-2549333-2.patch5.89 KB

Patch attached. Please review.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new geolocation-migrate_module_support-2549333-3.patch8.9 KB

Updated patch attached

Status: Needs review » Needs work

The last submitted patch, 3: geolocation-migrate_module_support-2549333-3.patch, failed testing.

The last submitted patch, 3: geolocation-migrate_module_support-2549333-3.patch, failed testing.

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs work » Needs review

Thanks for the email reminder. The first patch looks good. The 2nd patch seems to just add some code refactoring that should have its own seperate issue. Or did I miss something here?

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new interdiff-2549333-3-2.txt3.75 KB

Interdiff attached.

Changes between two versions:

  1. Migrate: missing hook_migrate_api() implementation added
  2. Migrate: fix incorrect URL to the Migrate help page
  3. Migrate: fix migration class to match naming conventions
  4. General: introduce a helper method for precalculation of values for a field. I've spotted that module itself uses the same code to generate values in 2 places (field presave and devel generate). The third place was migrate integration. I've decided to create a helper function that will do the work

derjochenmeyer’s picture

derjochenmeyer commented
Status: Needs review » Fixed

This makes perfect sense. Great. Thank you again. Lets test this further in the dev version.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Wow, thanks for such a quick review!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.