Closed (fixed)
Project:
Relation
Version:
7.x-1.x-dev
Component:
Dummy field
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
10 Aug 2015 at 13:00 UTC
Updated:
25 Aug 2015 at 10:54 UTC
Jump to comment: Most recent
The Relation dummy field module/formatter has 2 XSS issues, one on relation type (reverse) label (less critical, given the permissions required to create relation types, and since only the natural language formatter is vulnerable), and one on entity title/subject (more critical, given that less stringent permissions usually apply to editing/creating entities, and since all dummy field formatters are vulnerable.)
Properly escape entity titles when entities are displayed as subjects, and make sure relationship labels are sanitized prior to output.
Verify attached patch and test.
Text that was outputted unescaped prior to this patch will now be properly escaped.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| relation-dummy-field-xss.patch | 4.39 KB | mr.baileys |
Comments
Comment #2
mr.baileysComment #3
dpiPlease do not post security issues in the issue queue.
I have requested the attention of the security team. (https://security.drupal.org/node/156029)
Comment #4
mr.baileys@dpi: the Security Team deals with stable releases only, Relation is still in RC (see https://www.drupal.org/security-advisory-policy). Nevertheless, I discussed this issue with mikran prior to making it public, he agreed that it could be discussed in the public issue queue, hence my post here (I should have made it clear in the original issue that it was posted with permission).
Comment #5
dpiThank you for the clarification. I'm satisfied with the additional info you have provided :)
Comment #6
mr.baileysComment #7
mikran commentedThanks for this. I've tested and reviewed the fix and it is good as it is. New release incoming soon.
Comment #9
mikran commented