Problem/Motivation

The Relation dummy field module/formatter has 2 XSS issues, one on relation type (reverse) label (less critical, given the permissions required to create relation types, and since only the natural language formatter is vulnerable), and one on entity title/subject (more critical, given that less stringent permissions usually apply to editing/creating entities, and since all dummy field formatters are vulnerable.)

Proposed resolution

Properly escape entity titles when entities are displayed as subjects, and make sure relationship labels are sanitized prior to output.

Remaining tasks

Verify attached patch and test.

User interface changes

Text that was outputted unescaped prior to this patch will now be properly escaped.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
relation-dummy-field-xss.patch4.39 KBmr.baileys

Comments

mr.baileys created an issue. See original summary.

mr.baileys’s picture

Issue summary: View changes
dpi’s picture

Please do not post security issues in the issue queue.

I have requested the attention of the security team. (https://security.drupal.org/node/156029)

mr.baileys’s picture

@dpi: the Security Team deals with stable releases only, Relation is still in RC (see https://www.drupal.org/security-advisory-policy). Nevertheless, I discussed this issue with mikran prior to making it public, he agreed that it could be discussed in the public issue queue, hence my post here (I should have made it clear in the original issue that it was posted with permission).

dpi’s picture

Thank you for the clarification. I'm satisfied with the additional info you have provided :)

mr.baileys’s picture

mikran’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for this. I've tested and reviewed the fix and it is good as it is. New release incoming soon.

  • mikran committed 748031c on authored by mr.baileys
    Issue #2548749 by mr.baileys: XSS vulnerabilities in Relation Dummy...
mikran’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.