Problem/Motivation

Recent core change, test fails because some configuration settings don't have the langcode attribute.

Proposed resolution

Add the langcode attribute by switching mappings to a config_object/entity which already has that attribute defined.

Remaining tasks

Do it, provide patch, review and commit it.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 interdiff_2-4.txt692 bytesLKS90
#4 fix_missing_langcode-2548727-4.patch638 bytesLKS90
#2 fix_missing_langcode-2548727-2.patch844 bytesLKS90

Comments

LKS90 created an issue. See original summary.

LKS90’s picture

LKS90 commented
Status: Active » Needs review
StatusFileSize
new fix_missing_langcode-2548727-2.patch844 bytes

Here is the patch that switches all schema types which are missing the langcode attribute to config_objects.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/config/schema/monitoring.schema.yml
@@ -73,7 +73,7 @@ monitoring.sensor_config.*:
 monitoring.settings_base:
-  type: mapping
+  type: config_object
   mapping:
     result_logging:
       type: boolean
@@ -130,7 +130,7 @@ monitoring.settings.entity_aggregator:

@@ -130,7 +130,7 @@ monitoring.settings.entity_aggregator:
         label: The field to display
 
 monitoring.settings.monitoring_git_dirty_tree:
-  type: mapping
+  type: config_object
   label: 'Dirty git tree sensor settings'

For those two, mapping is (almost) correct. They are not to-level config objects, there are plugin settings.

One is base, that is correct. git should actually extend from monitoring.settings_base, so that should be the type.

LKS90’s picture

LKS90 commented
Status: Needs work » Needs review
StatusFileSize
new fix_missing_langcode-2548727-4.patch638 bytes
new interdiff_2-4.txt692 bytes

Even less changes now, yay :D.

Status: Needs review » Needs work

The last submitted patch, 4: fix_missing_langcode-2548727-4.patch, failed testing.

LKS90’s picture

LKS90 commented

Drupal\monitoring\Tests\MonitoringCaptchaTest: fixed and committed on Github, so only mirroring the changes?
Drupal\monitoring\Tests\MonitoringSearchAPITest: will have to take a look. The array definetly should not be empty.
Drupal\monitoring_demo\Tests\MonitoringDemoTest: fixed here

  • Berdir committed 3c46244 on 8.x-1.x authored by LKS90 
    Issue #2548727 by LKS90: Fix 'missing langcode in schema' errors
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Fixed

Yes, those are unrelated. committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

The last submitted patch, 2: fix_missing_langcode-2548727-2.patch, failed testing.

The last submitted patch, 2: fix_missing_langcode-2548727-2.patch, failed testing.

Status: Closed (fixed) » Needs work

The last submitted patch, 4: fix_missing_langcode-2548727-4.patch, failed testing.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Closed (fixed)