I see a WSOD when submitting a FlagResetForm --- "flag/reset/{flag}"

flag_reset_flag() should be replaced with a call to FlagService::reset()

I spotted this while manual testing a patch for #2547605: Flag service reset() queries database directly rather than using entity query manager service

I guess it is critical in the way all WSOD are.

CommentFileSizeAuthor
resetForm-0.patch532 bytesmartin107

Comments

martin107 created an issue. See original summary.

joachim’s picture

joachim commented
Status: Needs review » Fixed

Yikes, dunno how that got left off! We should always be doing a sanity-checking grep for names of functions when we remove them.

Thanks for the patch!

As a follow-up, we should figure out how to inject the flag service into the form as described here: https://www.drupal.org/node/2203931

  • joachim committed a5eee95 on 8.x-4.x authored by martin107 
    Issue #2548297 by martin107: Fixed broken call to removed function...
martin107’s picture

martin107 commented
Related issues: +#2548687: Inject flag service into FlagResetForm

Opened up followup.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.