For the sake of sane maintenance, this module could do with some tests. The bigger the module gets, the harder continued development becomes.

Plus, it's a way for me to map out exactly what the module does before getting further involved with the module.

CommentFileSizeAuthor
#5 simpltests-2547241-5.patch19.2 KBdeciphered

Comments

Deciphered created an issue. See original summary.

markhalliwell’s picture

markhalliwell
Primary language English
commented

Yes, it also needs to be refactored into OO. I just haven't gotten around to it. Feel free to create some, even if it's scaffolding (I'm not that great with tests tbh) :)

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

You should leverage the expertise of your colleague Fabian (LionsAd). I've been playing around in his Drupal TI (Travis CI integration) the last week or two, and it's some pretty amazing stuff.

But yes, will get some tests knocked up over the weekend.

markhalliwell’s picture

markhalliwell
Primary language English
commented

I try not to bother him with menial tasks for projects I develop. It's also worth nothing that when I created this project, I knew absolutely nothing about tests at all (nor Fabian :P), so it just evolved this way. I open this project in PHPStorm now and I'm ashamed lol

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Active » Needs review
StatusFileSize
new simpltests-2547241-5.patch19.2 KB

First pass, does basic functionality of the Icon API module as well as the functionality of all the sub-modules.

Status: Needs review » Needs work

The last submitted patch, 5: simpltests-2547241-5.patch, failed testing.

Status: Needs work » Needs review

Deciphered queued 5: simpltests-2547241-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: simpltests-2547241-5.patch, failed testing.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Hmm, passed locally. Will look into it more shortly.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs work » Needs review

Same tests work locally and on Travis CI (https://travis-ci.org/Decipher/Icon/builds/74670825). Methinks it's an issue with the D.o. Testbot. Running again, and if it fails again I'll open an issue.

Deciphered queued 5: simpltests-2547241-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: simpltests-2547241-5.patch, failed testing.

The last submitted patch, 5: simpltests-2547241-5.patch, failed testing.