The media_wysiwyg_hook_info() function defines the "media_wysiwyg_allowed_view_modes_alter" hook. Unfortunately, in media_wysiwyg_get_wysiwyg_allowed_view_modes() it's implemented as "media_wysiwyg_wysiwyg_allowed_view_modes_alter". This seems like it's just minor typo in the implementation.

CommentFileSizeAuthor
#4 2547219-fix-wysiwyg-view-modes-alter.patch1.61 KBdave reid
#2 broken-hook-media-wysiwyg-2547219-2.patch506 byteseric115

Comments

rwohleb created an issue. See original summary.

eric115’s picture

eric115 commented
StatusFileSize
new broken-hook-media-wysiwyg-2547219-2.patch506 bytes

Here is patch with a correction for the typo.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Hrm, this is a bit more complicated. I think the name of the hook in our media_wysiwyg_hook_info is actually correct (the word wysiwg not being duplicated). So we need to fix where this gets invoked, and for anyone that might have an implementation of the incorrect hook name, we need to still invoke the incorrect hook.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 2547219-fix-wysiwyg-view-modes-alter.patch1.61 KB

This is what I was thinking.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Tested and committed #4 to 7.x-2.x.

  • Dave Reid committed f3fcfd6 on 7.x-2.x 
    Issue #2547219 by Dave Reid, Eric115: Fixed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.