Issue #2510566-9: Adv CSS/JS Agg - If-Modified-Since warning reopened

I have (twice actually) the same warning on Status report, using Advagg 7.x-2.14, or last dev as of today.
My config D7.38 and Nginx/1.8.0 (a-la-perusio):
"Adv CSS/JS Agg - If-Modified-Since The If-Modified-Since (Last-Modified) header is being ignored by your web server.
The web servers configuration will need to be adjusted. The server should have responded with a 304, instead a 200 was returned."

However, when tested with https://varvy.com/tools/if-modified/ (Does your webpage support the 304 If Modified Since HTTP header?) the answer is YES.
This tool checked your HTTP headers and received this response ... Last-Modified: Wed, 05 Aug 2015 07:07:19 GMT
Tool then rechecked looking for if modified since support and found it... Server Response HTTP/1.1 304 Not Modified

Any clues ? Maybe the status report is not having this response asking from localhost instead of "external" ping ?
Thanks.

CommentFileSizeAuthor
#2 advagg-2546564-2-no-warn-if-etags-work-304.patch1.43 KBmikeytown2

Comments

pedrosp created an issue. See original summary.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Needs review
StatusFileSize
new advagg-2546564-2-no-warn-if-etags-work-304.patch1.43 KB

AdvAgg checks both the Etag/If-None-Match and the Last-Modified/If-Modified-Since header. If one of these works then 304s work. My guess is that Etag is working for you but the Last-Modified is not.

I think this patch should work in your case

pedrosp’s picture

pedrosp
Location Madrid, Spain
commented

Thank you for the patch, I' ve just installed it on the last dev, however the error reports remains the same.

It seems my server manage both headers, at least if checked "from the outside", as a visitor point of view.
This is an extract of the report : Last Modified Found.

Server Response HTTP/1.1 200 OK
HTTP/1.1 301 Moved Permanently
Server: nginx
Date: Thu, 13 Aug 2015 07:03:24 GMT
Content-Type: text/html
Content-Length: 178
Connection: keep-alive
Keep-Alive: timeout=10
X-XSS-Protection: 1; mode=block
X-Frame-Options: DENY
X-Content-Options: nosniff
HTTP/1.1 200 OK
Server: nginx
Date: Thu, 13 Aug 2015 07:03:25 GMT
Content-Type: text/html; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Keep-Alive: timeout=75
Vary: Accept-Encoding
Etag: "1439449404-0"
Content-Language: en
Link: ; rel="canonical",; rel="shortlink"
X-UA-Compatible: IE=Edge,chrome=1
Cache-Control: no-cache
Last-Modified: Thu, 13 Aug 2015 07:03:24 GMT
Expires: Thu, 01 Jan 1970 00:00:01 GMT
Vary: Cookie
Vary: Accept-Encoding
X-Micro-Cache: MISS
X-Content-Options: nosniff

Tool then rechecked looking for if modified since support and found it... "304 Not Modified" Received!

Server Response HTTP/1.1 304 Not Modified
HTTP/1.1 301 Moved Permanently
Server: nginx
Date: Thu, 13 Aug 2015 07:03:26 GMT
Content-Type: text/html
Content-Length: 178
Connection: keep-alive
Keep-Alive: timeout=10
X-XSS-Protection: 1; mode=block
X-Frame-Options: DENY
X-Content-Options: nosniff
HTTP/1.1 304 Not Modified
Server: nginx
Date: Thu, 13 Aug 2015 07:03:26 GMT
Connection: keep-alive
Keep-Alive: timeout=75
Etag: "1439449404-0"
Content-Language: en
Link: ; rel="canonical",; rel="shortlink"
X-UA-Compatible: IE=Edge,chrome=1
Cache-Control: no-cache
Last-Modified: Thu, 13 Aug 2015 07:03:24 GMT
Expires: Thu, 01 Jan 1970 00:00:01 GMT
Vary: Cookie
Vary: Accept-Encoding
X-Micro-Cache: HIT
X-Content-Options: no

  • mikeytown2 committed d5c904b on 7.x-2.x 
    Issue #2546564 by mikeytown2: No waring on status report page if only...
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Active

I've committed the etags patch from #2.

Will look into other options.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Closed (duplicate)

I think #2547367-19: Raw request info is empty fixes this issue. Please set the status back to active if this is not the case

cthshabel’s picture

cthshabel commented

Just to chime in I have applied the latest dev branch and I am still receiving the same symptoms. I also wrote about this issue here and didn't have the time to come back. But this time around I am determined to get this working. Will update with my findings too. Thanks @mikeytown2!

cthshabel’s picture

cthshabel commented

By "I am still receiving the same symptoms" I mean I receive the same headers as @pedrosp mentions in #3 here in this issue. Just to clarify.

cthshabel’s picture

cthshabel commented
Status: Closed (duplicate) » Active
cthshabel’s picture

cthshabel commented

Okay. Ultimately, the problem for me was the version of PHP that was installed on my Ubuntu 14.04 Trusty EC2 instance. I should have saved the original thread I found regarding the issue in an Ubuntu forum, but there was a problem with the package that comes with image on AWS. I upgraded PHP 5.6 via the tutorial here, which is not a standard package (I don't think). After the upgrade, these errors are resolved. Unfortunately, I am now experiencing gzip errors due to proxy settings as mentioned in the comment in this advagg issue, but I will comment there and/or start another issue. Thanks!

cthshabel’s picture

cthshabel commented
Status: Active » Closed (duplicate)

Moving back to closed (duplicate) that mikeytown2 set