Nice module, but the use of fadeOut causes the message to fade, and then the page to jump up to fill the space.

I think slideUp works better and makes the experience much smoother. Just my opinion, but patch attached for anyone interested.

CommentFileSizeAuthor
#9 messageclose_slideUp_D8_9.patch577 bytesbwaindwain
#2 messageclose_slideUp_D8.patch955 bytesbwaindwain
StatusMessageClose-SlideUp.patch565 bytesCollins405

Comments

Collins405 created an issue. See original summary.

bwaindwain’s picture

bwaindwain commented
StatusFileSize
new messageclose_slideUp_D8.patch955 bytes

Same patch for D8 branch

Also includes bug fix from https://www.drupal.org/project/messageclose/issues/3121802

nwom’s picture

nwom commented
Status: Active » Needs review

Setting to Needs Review, since a patch is attached. I have not tested it myself.

guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community

Both patches applies correctly and work as intended in each version!

RTBC +1

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 7.x-1.5 » 8.x-1.0
Category: Feature request » Bug report

You should always tag the highest version the issue appears on and then backport :) I would also classify it as a bug since the jumping of a page is not intended behaviour.

RTBC+1

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Version: 8.x-1.0 » 8.x-1.x-dev

I should have picked the dev version.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

This won't apply now. I wasn't 100% sure if this should be an option instead, as changing the default behavior is probably not a good thing. But I agree with Bram on #5 and this can be seen as a bug.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
bwaindwain’s picture

bwaindwain commented
Status: Needs work » Needs review
StatusFileSize
new messageclose_slideUp_D8_9.patch577 bytes

updated patch to work with latest dev