Nice module, but the use of fadeOut causes the message to fade, and then the page to jump up to fill the space.
I think slideUp works better and makes the experience much smoother. Just my opinion, but patch attached for anyone interested.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | messageclose_slideUp_D8_9.patch | 577 bytes | bwaindwain |
| #2 | messageclose_slideUp_D8.patch | 955 bytes | bwaindwain |
| StatusMessageClose-SlideUp.patch | 565 bytes | Collins405 |
Comments
Comment #2
bwaindwain commentedSame patch for D8 branch
Also includes bug fix from https://www.drupal.org/project/messageclose/issues/3121802
Comment #3
nwom commentedSetting to Needs Review, since a patch is attached. I have not tested it myself.
Comment #4
guilhermevp commentedBoth patches applies correctly and work as intended in each version!
RTBC +1
Comment #5
bramdriesenYou should always tag the highest version the issue appears on and then backport :) I would also classify it as a bug since the jumping of a page is not intended behaviour.
RTBC+1
Comment #6
bramdriesenI should have picked the dev version.
Comment #7
penyaskitoThis won't apply now. I wasn't 100% sure if this should be an option instead, as changing the default behavior is probably not a good thing. But I agree with Bram on #5 and this can be seen as a bug.
Comment #8
penyaskitoComment #9
bwaindwain commentedupdated patch to work with latest dev