Nice module, but the use of fadeOut causes the message to fade, and then the page to jump up to fill the space.

I think slideUp works better and makes the experience much smoother. Just my opinion, but patch attached for anyone interested.

Comments

Collins405 created an issue. See original summary.

bwaindwain’s picture

StatusFileSize
new955 bytes

Same patch for D8 branch

Also includes bug fix from https://www.drupal.org/project/messageclose/issues/3121802

nwom’s picture

Status: Active » Needs review

Setting to Needs Review, since a patch is attached. I have not tested it myself.

guilhermevp’s picture

Status: Needs review » Reviewed & tested by the community

Both patches applies correctly and work as intended in each version!

RTBC +1

bramdriesen’s picture

Version: 7.x-1.5 » 8.x-1.0
Category: Feature request » Bug report

You should always tag the highest version the issue appears on and then backport :) I would also classify it as a bug since the jumping of a page is not intended behaviour.

RTBC+1

bramdriesen’s picture

Version: 8.x-1.0 » 8.x-1.x-dev

I should have picked the dev version.

penyaskito’s picture

Status: Reviewed & tested by the community » Needs work

This won't apply now. I wasn't 100% sure if this should be an option instead, as changing the default behavior is probably not a good thing. But I agree with Bram on #5 and this can be seen as a bug.

penyaskito’s picture

bwaindwain’s picture

Status: Needs work » Needs review
StatusFileSize
new577 bytes

updated patch to work with latest dev