Monitoring is currently 'broken' because the MonitoringCoreKernel test fails. The fail itself is caused by the shortenFilename() functionality. The test does not remove the DRUPAL_ROOT from the filename and fails. Adding a line to update the assertion message solves the problem.
Edit the logged message after logging to strip the DRUPAL_ROOT from the filepath. Since the logged error is modified by the sensor, the test has to do so as well.
Review patch, commit.
None
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff_0-4.txt | 2.64 KB | LKS90 |
| #4 | fix_php_notices_test-2545168-4.patch | 2.68 KB | LKS90 |
| fix_PHP_notices_test_fails-XXXXXXXX-0.patch | 1.63 KB | LKS90 |
Comments
Comment #1
sasanikolic commentedSeems like an easy test-only fix.
Comment #3
berdirIf the tests are broken then why aren't they failing? (apart from the search api test fails)
Comment #4
LKS90 commentedIt's the DRUPAL_ROOT problem again, the tests only fail locally, when run in a subdirectory (like the testbot) everything"s good. But when the DRUPAL_ROOT happens to be
/usr/local/var/www/d8/www, the test will fail because the sensor message has that part removed and the original error which is asserted hasn't. I switched it now that the logged error message uses the DRUPAL_ROOT variable, so the filename shortening happens on all environments, not just on those that fit the environment of my originally logged error.Comment #7
berdirCommitted.