Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem when you use both Omega and Advagg on a site:
Notice: Undefined index: type in omega_group_js() (line 57 of omega/omega/includes/scripts.inc).
Notice: Undefined index: type in omega_pre_render_scripts() (line 287 of omega/omega/includes/scripts.inc).
Notice: Undefined index: data in advagg_generate_groups() (line 733 of advagg/advagg.inc).
Both want to do their JS grouping, but we want to trust Advagg with that.
Proposed solution: only register the scripts element if Advagg is NOT enabled.
Comment | File | Size | Author |
---|---|---|---|
#2 | omega-advagg-disable-2544758-2.patch | 876 bytes | klausi |
Comments
Comment #1
klausiComment #2
klausiPatch attached.
Comment #3
fubhy CreditAttribution: fubhy commentedLooks like AdvAgg already took care of this? http://cgit.drupalcode.org/advagg/tree/advagg.module#n704
Comment #4
klausiAha, I should have updated advagg and tested that. Let me do that and report back.
Comment #5
fubhy CreditAttribution: fubhy commentedAlso related: #2543430: A code modification is needed for this theme to work with Advagg module
Comment #6
klausiYep, the advagg updated fixed this issue for me, so no patch necessary :-)