Problem when you use both Omega and Advagg on a site:

Notice: Undefined index: type in omega_group_js() (line 57 of omega/omega/includes/scripts.inc).
Notice: Undefined index: type in omega_pre_render_scripts() (line 287 of omega/omega/includes/scripts.inc).
Notice: Undefined index: data in advagg_generate_groups() (line 733 of advagg/advagg.inc).

Both want to do their JS grouping, but we want to trust Advagg with that.

Proposed solution: only register the scripts element if Advagg is NOT enabled.

CommentFileSizeAuthor
#2 omega-advagg-disable-2544758-2.patch876 bytesklausi

Comments

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Issue summary: View changes
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Needs review
StatusFileSize
new omega-advagg-disable-2544758-2.patch876 bytes

Patch attached.

fubhy’s picture

fubhy commented

Looks like AdvAgg already took care of this? http://cgit.drupalcode.org/advagg/tree/advagg.module#n704

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Postponed (maintainer needs more info)

Aha, I should have updated advagg and tested that. Let me do that and report back.

fubhy’s picture

fubhy commented

Also related: #2543430: A code modification is needed for this theme to work with Advagg module

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

Yep, the advagg updated fixed this issue for me, so no patch necessary :-)