The idea is to add twitter-atreply, twitter-hashtag & twitter-timeline-link to identify different link types (mention, hashtag & timeline link) like it's done on twitter.

The main goal of this feature is to offer more design options for designers .

CommentFileSizeAuthor
#19 twitter_extra_class-2544672-19-7.x-5.x.patch961 bytesgurvan
#11 twitter-n2544672-11-6.x-5.x.patch1.93 KBdamienmckenna
#10 twitter-n2544672-10-7.x-5.x.patch2.04 KBdamienmckenna
#9 twitter-n2544672-9-7.x-6.x.patch2.04 KBdamienmckenna
#6 twitter-n2544672-6-6.x-5.x.patch1.93 KBdamienmckenna
#5 twitter-n2544672-4-7.x-5.x.patch2.03 KBdamienmckenna
#3 twitter-n2544672-3-7.x-6.x.patch2.03 KBdamienmckenna
#1 twitter_extra_class-2544672.patch1.38 KBgurvan

Comments

gurvan’s picture

gurvan commented
StatusFileSize
new twitter_extra_class-2544672.patch1.38 KB
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
StatusFileSize
new twitter-n2544672-3-7.x-6.x.patch2.03 KB

I've updated this slightly so that _twitter_filter_text() has a new argument to insert a class, rather than it deciding what the class should be.

Status: Needs review » Needs work

The last submitted patch, 3: twitter-n2544672-3-7.x-6.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
Status: Needs work » Needs review
StatusFileSize
new twitter-n2544672-4-7.x-5.x.patch2.03 KB

Ported to 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new twitter-n2544672-6-6.x-5.x.patch1.93 KB

Ported to 6.x-5.x.

The last submitted patch, 5: twitter-n2544672-4-7.x-5.x.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 6: twitter-n2544672-6-6.x-5.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 7.x-6.x-dev
Status: Needs work » Needs review
StatusFileSize
new twitter-n2544672-9-7.x-6.x.patch2.04 KB

I fail at php.

A fixed patch for 7.x-6.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-6.x-dev » 7.x-5.x-dev
StatusFileSize
new twitter-n2544672-10-7.x-5.x.patch2.04 KB

Fixed patch for 7.x-5.x.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-5.x-dev » 6.x-5.x-dev
StatusFileSize
new twitter-n2544672-11-6.x-5.x.patch1.93 KB

Fixed patch for 6.x-5.x.

The last submitted patch, 9: twitter-n2544672-9-7.x-6.x.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 263fff3 on 6.x-5.x authored by gurvan 
    Issue #2544672 by gurvan, DamienMcKenna: Add classes to linked inserted...

  • DamienMcKenna committed cf3bef1 on authored by gurvan 
    Issue #2544672 by gurvan, DamienMcKenna: Add classes to linked inserted...
gurvan’s picture

gurvan commented

Great cool add-on for designers ;)

  • DamienMcKenna committed d2eeea4 on 7.x-6.x authored by gurvan 
    Issue #2544672 by gurvan, DamienMcKenna: Add classes to linked inserted...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gurvan’s picture

gurvan commented
StatusFileSize
new twitter_extra_class-2544672-19-7.x-5.x.patch961 bytes

I resubmit a small patch to fix css classes names according to the twitter API

twitter-atreply, twitter-hashtag & twitter-timeline-link

& not twitter-timeline-atreply, twitter-timeline-hashtag & twitter-timeline-link

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 6.x-5.x-dev » 7.x-5.x-dev
Status: Closed (fixed) » Needs review

  • DamienMcKenna committed 858997e on 7.x-6.x authored by gurvan 
    Issue #2544672 by gurvan: Fixed the classes added to embedded links to...

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed
Parent issue: » #2572751: Plan for Twitter v7.x-5.11 release
Related issues: +#2572749: Plan for Twitter v7.x-6.2 release, +#2572747: Plan for Twitter v6.x-5.4 release

Committed to all three branches. Thanks!

  • DamienMcKenna committed f951b67 on 7.x-5.x authored by gurvan 
    Issue #2544672 by gurvan: Fixed the classes added to embedded links to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.