Problem/Motivation

drupal_render_children() is being marked as deprecated so all usages of that function should be removed in Drupal core.

Proposed resolution

Replace drupal_render_children() usage with render().

Remaining tasks

Fix it!
Review!

User interface changes

-

API changes

-

Data model changes

-

CommentFileSizeAuthor
#4 remove-2544178-4.patch649 bytesborisson_
#4 interdiff.txt706 bytesborisson_
#2 remove-2544178-2.patch598 byteslauriii

Comments

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Parent issue: » #2544156: Deprecate drupal_render_children()
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new remove-2544178-2.patch598 bytes

Status: Needs review » Needs work

The last submitted patch, 2: remove-2544178-2.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt706 bytes
new remove-2544178-4.patch649 bytes

This makes sure the test pass, but it's not a good solution because it introduces a new SafeMarkup::set

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Needs work

We don't want to add new SafeMarkup::set() calls so the solution has to be something else

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Fixed

This seems to be fixed in Drupal core so no need to remove it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.