The d6_upload migration has no dependency on the upload field instance - the introduction of proper dependency sorting (#2513028: Migration dependency ordering should be in migrate, not migrate_drupal) results in it running before d6_field_upload and d6_field_upload_instance, thus failing.

I've run into other problems triggered by fixing this dependency in that issue, let's see how it does with testbot.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, d6_upload-dependency.patch, failed testing.

mikeryan’s picture

Status: Needs work » Needs review
FileSize
1.05 KB
507 bytes

Modify the test to fulfill the new dependency.

mikeryan’s picture

phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

Looks divine.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

The patch looks straight-forward. The only thing I was confused about is why there were no tests to show whatever got broken got fixed. @mikeryan explained that this doesn't actually break anything in HEAD; the work done in #2513028: Migration dependency ordering should be in migrate, not migrate_drupal will expose the error, and the tests there will also ensure we don't break this again.

Works for me. Committed and pushed to 8.0.x. Thanks!

  • webchick committed ce9a128 on 8.0.x
    Issue #2543768 by mikeryan: Missing dependencies in d6_upload
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.