Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The d6_upload migration has no dependency on the upload field instance - the introduction of proper dependency sorting (#2513028: Migration dependency ordering should be in migrate, not migrate_drupal) results in it running before d6_field_upload and d6_field_upload_instance, thus failing.
I've run into other problems triggered by fixing this dependency in that issue, let's see how it does with testbot.
Comment | File | Size | Author |
---|---|---|---|
#2 | interdiff.txt | 507 bytes | mikeryan |
#2 | missing_dependencies_in-2543768-2.patch | 1.05 KB | mikeryan |
Comments
Comment #2
mikeryanModify the test to fulfill the new dependency.
Comment #3
mikeryanBlocking #2513028: Migration dependency ordering should be in migrate, not migrate_drupal.
Comment #4
phenaproximaLooks divine.
Comment #5
webchickThe patch looks straight-forward. The only thing I was confused about is why there were no tests to show whatever got broken got fixed. @mikeryan explained that this doesn't actually break anything in HEAD; the work done in #2513028: Migration dependency ordering should be in migrate, not migrate_drupal will expose the error, and the tests there will also ensure we don't break this again.
Works for me. Committed and pushed to 8.0.x. Thanks!