In the 2.x branch the README instructs the developer to include the system module's drupal.ajax library. This means that none of the dialog javascript gets loaded and the dialog does not appear. This same method is also used in the sub modules for comments, nodes and user dialogs which means they don't work.

The correct method is to call $build['#attached']['library'][] = array('dialog', 'drupal.dialog.ajax');

CommentFileSizeAuthor
#3 2543576-3.patch1.9 KBdevin carlson
#1 incorrect_library-2543576-1.patch2.28 KBtanc

Comments

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented
Status: Active » Needs review
StatusFileSize
new incorrect_library-2543576-1.patch2.28 KB

Attached is a patch which updates the README.txt and the sub modules and should allow the modules to work correctly.

botris’s picture

botris
Primary language Dutch
Location Creuse, France
commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Confirming this. Basically it doesn't work without including drupal.dialog.ajax

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2543576-3.patch1.9 KB

The drupal.ajax library includes misc/ajax.js which should call the appropriate Dialog commands. However, I am able to reproduce the drupal.dialog.ajax library missing from the response in some cases.

The attached patch should fix that.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Tested #3 and committed to Dialog 7.x-2.x.

Please reopen this issue if you're still having problems.

tanc’s picture

tanc
he/him
Primary language English
Location Italy
commented

Confirming that with the changes in #3 the module now works correctly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.