Problem/Motivation

There are many $controller variables. In D8 we are using plugins.

Proposed resolution

We should rename them to $plugin.

Avoid clashes with other patches...
Minor since it does not affect any outer API and is just internal cleanup.

CommentFileSizeAuthor
#2 rename_controller_to-2543564-2.patch16.62 KBedurenye

Comments

edurenye’s picture

edurenye commented

Waiting for this issue to be commited: https://www.drupal.org/node/2538360

edurenye’s picture

edurenye commented
Status: Active » Needs review
StatusFileSize
new rename_controller_to-2543564-2.patch16.62 KB

The othere issue is closed, so I did rebase and here is the patch.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/src/Entity/Translator.php
@@ -347,8 +347,8 @@ class Translator extends ConfigEntityBase implements TranslatorInterface {
+    if ($plugin = $this->getPlugin()) {
+      return $plugin->getNotCanTranslateReason($job);

Mind that this conflicts with #1420364: A simple response object for methods which need to return a true/false *and* a message
But the other issue is stuck since 7 days so i propose to commit it and rebase the other issue when continuing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

The other issue isn't ready, so lets get this in.

  • Berdir committed 442d19e on 8.x-1.x authored by edurenye 
    Issue #2543564 by edurenye: Rename $controller to $plugin

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.