Problem/Motivation

Background (fillcolor) for circle style is always black for non-default styles and white for default one. It doesn't respect custom values stored under style.

Proposed resolution

In Circle.js file change name of field from data.opt.color to data.opt.fillcolor

Remaining tasks

  • Post a patch
  • Review and get RTBC
  • Commit

User interface changes

n/a

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#1 use_fillcolor_property-2543326-1.patch1.27 KBzaporylie
Screen Shot 2015-07-31 at 10.38.18.png14.11 KBzaporylie
Screen Shot 2015-07-31 at 10.37.45.png13.79 KBzaporylie

Comments

zaporylie’s picture

zaporylie
he/him
Primary language Polish
commented
Title: Use fillcolor property (instead of color) for custom Circle styles » Use fillcolor property (instead of color) in circle styles
Status: Needs work » Needs review
StatusFileSize
new use_fillcolor_property-2543326-1.patch1.27 KB
pol’s picture

pol
Location Brussels
commented
Status: Needs review » Fixed

Thanks ! I had it committed in the meantime :)

  • Pol committed 9f02d35 on 7.x-3.x 
    Issue #2543326: Use fillcolor property for custom Circle styles.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.