Remove Media integration

Good idea. Since CKEditor is incompatible to the new 2.0 version of media anyway, this needed to happen.

The CKEditor module should just implement the CKEditor itself and provide hooks and APIs to extend it.
It does that pretty good. So I think this is the right step to do.

Here's a patch that removes the media plugin and references to the plugin.

I've posted a corresponding patch in #2542276: Integration with Media 1.x to include the plugin there in the 1.x branch and move Media 2.x code to a 2.x branch.

Rerolled patch and removed icon lines that apparently kept it from applying.

#6 patch fixed the problem.
Thx!

Since CKEditor is incompatible to the new 2.0 version of media anyway, this needed to happen.

@func0der, where did you get this information? I seem to be using Media 2.0 fine with the CKeditor module...

@pianomansam

Do you have the latest version of Media running?

That version does not have the function ` media_browser_js()` anymore, because it is not solved by including the libraries via `drupal_add_library()`.
So the CKEditor module will fail to include the media browser.
This is of course fixable, but a separation of the CKEditor module itself and the media integration is the way to go here, so both parts of the module get to be easier to maintain.

@func0der, I'm running latest ckeditor and media modules with this patch applied (https://www.drupal.org/node/2455391#comment-9943365). I'm also running the media_ckeditor module.

@pianomansam

Don't thank: https://www.drupal.org/node/2555409

P.S. I have applied the patch, thought I dunno if this matters or not.

How do I go ahead when using the CDN version of ckeditor?

In which folder do you put this file, please ?

@si.shy Put the file in module root directory. Then apply the patch on a terminal:

patch -p1 < ckeditor-remove_media_integration-2542566-5.patch

It looks like there are a few ideas on how to proceed at this point:

1) Install the patch posted 2 months ago in post #6.

2) Install the patch referred to in comments #4 and #25 of Call to undefined function media_browser_js() latest Media-7.x-2.x-dev and #5 of Remove JS helper functions.

3) Follow instructions posted a month ago at How to: CKEditor + Media integration:

1) Update Media to #844baf+ (this is a git commit id)
2) Update CKEditor to #32f097+
3) Apply database updates and rebuild registry (drush rr; drush updatedb)
4) Install a new module Media CKEditor (of which you had no idea before and on which nothing would even hint to)
5) Enable all above and Media WYSIWYG module.
6) Now configure CKeditor profile to enable both the button for inserting Media files and "Plugin for embedding files using Media CKEditor" checkbox under "Editor Appearance" - this is a new name for the plugin.

I figured I'd try the simplest approach first, and then wait for version releases fixing everything. Approach 2) is the simplest of the group; I applied the patch and fortunately it appears to work (using Media 7.x-2.0-beta1, File Entity 7.x-2.0-beta2 and CKEditor 7.x-1.16)