Problem/Motivation

The module inconsistently uses bool / boolean in docblock as type declaration.

Proposed resolution

./src/JobItemInterface.php:409:   * @return bool
./src/SourcePluginInterface.php:36:   * @return boolean
./src/SourcePluginUiBase.php:162:   * @return bool
./src/TranslatorInterface.php:135:   * @return bool
./src/TranslatorInterface.php:143:   * @return bool
./src/TranslatorInterface.php:198:   * @return bool
./src/TranslatorInterface.php:207:   * @return bool
./src/TranslatorPluginInterface.php:25:   * @return boolean
./src/TranslatorPluginInterface.php:51:   * @return boolean
./src/TranslatorPluginInterface.php:201:   * @return boolean

(And more...)

Caution, some of these changes currently clash with other issues / patches. Let's wait until the current API changes are committed.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

miro_dietiker’s picture

Status: Active » Needs review
StatusFileSize
new8.41 KB

A first diff after hunting boolean cases.

Status: Needs review » Needs work

The last submitted patch, 1: tmgmt_2542538_bool.patch, failed testing.

The last submitted patch, 1: tmgmt_2542538_bool.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: tmgmt_2542538_bool.patch, failed testing.

Status: Needs work » Needs review

juanse254 queued 1: tmgmt_2542538_bool.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: tmgmt_2542538_bool.patch, failed testing.

miro_dietiker’s picture

Status: Needs work » Needs review
StatusFileSize
new0 bytes

Retrying, without some modified _access string.

  • miro_dietiker committed 1bc408d on 8.x-1.x
    Issue #2542538 by miro_dietiker: Properly annotate booleans in docblock
    
miro_dietiker’s picture

Status: Needs review » Fixed

Committed. :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.