Problem/Motivation

Fix config schema

Proposed resolution

Remove the strictSchemaChecking = FALSE in the tests and make them pass.

Remaining tasks

None.

User interface changes

None.

API changes

Route renames.

Data model changes

None.

CommentFileSizeAuthor
#6 interdiff-2541936-5-6.txt2.22 KBgiancarlosotelo
#6 fix_config_schema-2541936-6.patch5.7 KBgiancarlosotelo
#5 interdiff-2541936-1-5.txt3.58 KBgiancarlosotelo
#5 fix_config_schema-2541936-5.patch5.76 KBgiancarlosotelo
#1 fix_config_schema-2541936-1.patch4.91 KBgiancarlosotelo

Comments

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new fix_config_schema-2541936-1.patch4.91 KB

Tests are green now.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented 
+++ b/config/schema/flag.schema.yml
@@ -55,3 +55,53 @@ flag.flag.*:
       label: 'ID of the Link Type plugin'
+    flagTypeConfig:
+      type: mapping
+      label: 'Flag Type Configuration'

Nice.

The problem now is that those two are plugin-based configuration.

So they can be different based on the used link type.

So we need a dynamic schema, based on the value of the plugin, and at least for the flag type, it probably also needs a wildcard as that is automatically exposed for all entity types.

See search_api.schema.yml for an example for the dynamic definition and search_api.datasources.schema.yml for an example of a dynamic wildcard thing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work
giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new fix_config_schema-2541936-5.patch5.76 KB
new interdiff-2541936-1-5.txt3.58 KB

Added a dynamic schema for flag type and link type.

giancarlosotelo’s picture

giancarlosotelo commented
StatusFileSize
new fix_config_schema-2541936-6.patch5.7 KB
new interdiff-2541936-5-6.txt2.22 KB

I delete one 'flag.' string and also works. It is cleaner now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Nice!

joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Brilliant! This was a major issue with our tests. Thanks for working on it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.