When a user installs the module, there's no need to check if their default project has a callback URL. We need their new site's URL, so I've changed the code in all the pertinent places so it's directional from the module to the TMS.

CommentFileSizeAuthor
#3 2541542-3.patch2.57 KBpenyaskito
#1 2541542-directional-callback.patch3.45 KBjbhovik

Comments

jbhovik’s picture

jbhovik commented
StatusFileSize
new 2541542-directional-callback.patch3.45 KB

  • jbhovik committed cf535a9 on 8.x-1.x 
    Issue #2541542 by jbhovik: Modify callback assignment code for...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2541542-3.patch2.57 KB

I modified this for adding named routes and avoiding string concatenations.

  • penyaskito committed 98a30db on 8.x-1.x 
    Issue #2541542 by jbhovik, penyaskito: Modify callback assignment code...
jbhovik’s picture

jbhovik commented
Status: Needs review » Reviewed & tested by the community

Code looks good. That's a good addition.

Tested demo user and my user from module installation and utilities form, and everything worked.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Let's mark this one as fixed, we will need to figure out later how we handle this when a site is deployed from config.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.