It is not clear if conditional voting requires a user to meet all conditions or any condition.

CommentFileSizeAuthor
#4 election-conditional_message-2541414-4-D7.patch988 bytesliam morland
#1 election-conditional_message-2541414-1-D7.patch698 bytesliam morland

Comments

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new election-conditional_message-2541414-1-D7.patch698 bytes
pjcdawkins’s picture

pjcdawkins commented 
+++ b/election_condition/election_condition.module
@@ -90,7 +90,7 @@ function election_condition_form_election_post_form_alter(&$form, &$form_state)
       '#prefix' => '<div class="form-item"><label for="edit-conditions">',

Er. Is there an unclosed <div> there? oops. Your patch itself is correct.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

You are right and that is not the only HTML issue. The message should not be in a label element; label elements need to have a for attribute that points to a form control.

The "Assign conditions" message should probably be the #description of the fieldset.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new election-conditional_message-2541414-4-D7.patch988 bytes

pjcdawkins’s picture

pjcdawkins commented
Status: Needs review » Fixed

Much better. Thanks (again)!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.