Problem/Motivation

When on "Add Translation" page (admin/config/regional/tmgmt_translator/add) there are some errors.

1.) Use of undefined constant STREAM_WRAPPERS_WRITE_VISIBLE in Drupal\tmgmt_file\FileTranslatorUi->pluginSettingsForm() (line 48...).

2.) Undefined index: description in Drupal\tmgmt_file\FileTranslatorUi->pluginSettingsForm() (line 49...).

Proposed resolution

Fix them.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 interdiff-2541100-3-7.txt2.91 KBgiancarlosotelo
#7 fix_error_add_translator-2541100-7.patch4.5 KBgiancarlosotelo
#3 fix_error_add_translator-2541100-3.patch1.19 KBgiancarlosotelo

Comments

sasanikolic’s picture

sasanikolic commented
Title: Solve errors on add translator page » Fix errors on add translator page
sasanikolic’s picture

sasanikolic commented
Component: Translator: Local » Translator: File
giancarlosotelo’s picture

giancarlosotelo commented
Status: Active » Needs review
StatusFileSize
new fix_error_add_translator-2541100-3.patch1.19 KB

Returned array from \Drupal::service('stream_wrapper_manager')->getWrappers() doesn't have a field description. So I am getting the descriptions from \Drupal::service('stream_wrapper_manager')->getDescriptions and also using the interface StreamWrapperInterface to get the constant.

sasanikolic’s picture

sasanikolic commented
Status: Needs review » Reviewed & tested by the community

Seems ok to me.

sasanikolic’s picture

sasanikolic commented
Status: Reviewed & tested by the community » Needs work

Reverting back what I just said, tested it and this is the error I get now:

Warning: htmlspecialchars() expects parameter 1 to be string, array given in Drupal\Component\Utility\SafeMarkup::checkPlain() (line 250 of core/lib/Drupal/Component/Utility/SafeMarkup.php).

juanse254’s picture

juanse254 commented

Seems to be working for me, please add test coverage.

giancarlosotelo’s picture

giancarlosotelo commented
Status: Needs work » Needs review
StatusFileSize
new fix_error_add_translator-2541100-7.patch4.5 KB
new interdiff-2541100-3-7.txt2.91 KB

Added test and changes in the schema for the test works well.

juanse254’s picture

juanse254 commented

good to go in my opinion.

juanse254’s picture

juanse254 commented
Status: Needs review » Reviewed & tested by the community
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Looks good, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.