Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
When on "Add Translation" page (admin/config/regional/tmgmt_translator/add) there are some errors.
1.) Use of undefined constant STREAM_WRAPPERS_WRITE_VISIBLE in Drupal\tmgmt_file\FileTranslatorUi->pluginSettingsForm() (line 48...).
2.) Undefined index: description in Drupal\tmgmt_file\FileTranslatorUi->pluginSettingsForm() (line 49...).
Proposed resolution
Fix them.
Remaining tasks
User interface changes
API changes
Data model changes
Comment | File | Size | Author |
---|---|---|---|
#7 | interdiff-2541100-3-7.txt | 2.91 KB | giancarlosotelo |
#7 | fix_error_add_translator-2541100-7.patch | 4.5 KB | giancarlosotelo |
#3 | fix_error_add_translator-2541100-3.patch | 1.19 KB | giancarlosotelo |
Comments
Comment #1
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedComment #2
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedComment #3
giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commentedReturned array from
\Drupal::service('stream_wrapper_manager')->getWrappers()
doesn't have a field description. So I am getting the descriptions from\Drupal::service('stream_wrapper_manager')->getDescriptions
and also using the interfaceStreamWrapperInterface
to get the constant.Comment #4
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedSeems ok to me.
Comment #5
sasanikolic CreditAttribution: sasanikolic at MD Systems GmbH commentedReverting back what I just said, tested it and this is the error I get now:
Warning: htmlspecialchars() expects parameter 1 to be string, array given in Drupal\Component\Utility\SafeMarkup::checkPlain() (line 250 of core/lib/Drupal/Component/Utility/SafeMarkup.php).
Comment #6
juanse254 CreditAttribution: juanse254 at MD Systems GmbH commentedSeems to be working for me, please add test coverage.
Comment #7
giancarlosotelo CreditAttribution: giancarlosotelo at MD Systems GmbH commentedAdded test and changes in the schema for the test works well.
Comment #8
juanse254 CreditAttribution: juanse254 at MD Systems GmbH commentedgood to go in my opinion.
Comment #9
juanse254 CreditAttribution: juanse254 at MD Systems GmbH commentedComment #10
BerdirLooks good, committed.