Tested a round trip API callback path on a live server. From node creation to upload to request target languages to download.

CommentFileSizeAuthor
#3 2540962-live-server-callbacks-1.patch503 bytesjbhovik
#1 2540962-live-server-callbacks.patch3.23 KBjbhovik

Comments

jbhovik’s picture

jbhovik commented
StatusFileSize
new 2540962-live-server-callbacks.patch3.23 KB
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Needs work 
+++ b/src/LingotekTranslatableEntity.php
@@ -110,29 +110,36 @@ class LingotekTranslatableEntity {
+    if ($lock->acquire(__FUNCTION__)) {
...
+        return FALSE;

We should release the lock before returning in that case.

jbhovik’s picture

jbhovik commented
StatusFileSize
new 2540962-live-server-callbacks-1.patch503 bytes

Nice catch.

jbhovik’s picture

jbhovik commented
Status: Needs work » Needs review

  • jbhovik committed d220924 on 8.x-1.x 
    Issue #2540962 by jbhovik, penyaskito: Callback logic for automatic...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Fixed

Awesome, thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.