Problem/Motivation

Token API has been updated to consider cacheability metadata.
The change record for more information: Token replacement needs to consider cacheability metadata

Proposed resolution

Update simplenews_tokens() with the API changes.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 update_simplenews_with-2539284-2-interdiff.txt2.65 KBmbovan
#2 update_simplenews_with-2539284-2.patch3.29 KBmbovan
#1 update_simplenews_with-2539284-1.patch1.22 KBmbovan

Comments

mbovan’s picture

mbovan commented
Status: Active » Needs review
StatusFileSize
new update_simplenews_with-2539284-1.patch1.22 KB

Providing a patch... Not sure if we should have some addCacheableDependency() calls?

mbovan’s picture

mbovan commented
StatusFileSize
new update_simplenews_with-2539284-2.patch3.29 KB
new update_simplenews_with-2539284-2-interdiff.txt2.65 KB

Providing a patch based on the feedback from @Berdir.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks, committed.

  • Berdir committed aa1ae04 on 8.x-1.x authored by mbovan 
    Issue #2539284 by mbovan: Update Simplenews with Token changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.