Notice: Undefined index: logo in zurb_foundation_form_system_theme_settings_alter() (line 33 of /zurb_foundation/theme-settings.php).
Notice: Undefined index: favicon in zurb_foundation_form_system_theme_settings_alter() (line 36 of /zurb_foundation/theme-settings.php).

Not sure what it's related to, maybe both of these not being supplied as settings, zurb gets mad as its not settings a default of nothing initially (maybe?). Only appears occasionally on sites and only on the theme settings php.

CommentFileSizeAuthor
#3 themesettingsnotice-2538930-3.patch879 byteshongpong

Comments

heatherwoz’s picture

heatherwoz commented
Issue summary: View changes

This will happen if you disable the feature in the .info file, because the Zurb parent theme tries to unset the value even though Drupal has removed it from the form as an unsupported feature. As a workaround, you can leave the feature enabled in .info and unset the fields in your subtheme_form_system_theme_settings_alter so they won't show up on the theme configuration page:

  unset($form['zurb_foundation']['general']['theme_settings']['toggle_logo']);
  unset($form['zurb_foundation']['general']['logo']);
hongpong’s picture

hongpong commented

Can we find a patch for this? I would think that using isset() to check for the value's existence would remove the problem, and put this on 7.x-5.x.

hongpong’s picture

hongpong commented
StatusFileSize
new themesettingsnotice-2538930-3.patch879 bytes

This should prevent the notice, it just checks if that form element is set first.

hongpong’s picture

hongpong commented
Status: Active » Needs review

the patch also applies cleanly on 7.x-4.x so i would commit it on there as well.

bhumikavarshney’s picture

bhumikavarshney commented
Status: Needs review » Reviewed & tested by the community

Hi @HongPong ,
The patch works fine for me .
Thanks