Use phpspec/prophecy for mocks

WoW this looks awesome.

+++ b/tests/src/Unit/BlockDisplayVariantTest.php
@@ -123,40 +98,34 @@ public function testBuildNoCache() {
     $display_variant = $this->getMockBuilder(BlockDisplayVariant::class)
-      ->setConstructorArgs([['page_title' => $page_title], 'test', array(), $context_handler, $account, $uuid_generator, $token])
-      ->setMethods(array('getBlockCollection', 'drupalHtmlClass', 'renderPageTitle'))
+      ->setConstructorArgs([['page_title' => $page_title], 'test', [], $context_handler->reveal(), $account->reveal(), $uuid_generator->reveal(), $token])
+      ->setMethods(['getBlockCollection', 'drupalHtmlClass', 'renderPageTitle'])
       ->getMock();
...
     $display_variant->expects($this->once())
       ->method('getBlockCollection')
-      ->will($this->returnValue($block_collection));
+      ->willReturn($block_collection);
     $display_variant->expects($this->once())
       ->method('renderPageTitle')
       ->with($page_title)
-      ->will($this->returnValue($page_title));
+      ->willReturn($page_title);

prophesize can't handle partial mocks?

They don't want to support it by design, see https://github.com/phpspec/prophecy/issues/101.

In an ideal world phpunit would have used mockery.

#3 #4: Yeah, sadly not.

Mockery shines when using partial or even Mocks for classes that do not exist, e.g. interfaces that are not defined.

However Prophecy is really great in overwriting the behavior of a defined mock per test class and also the dynamic binding of allowing a setter to overwrite the expectation of a getter is really great.

http://everzet.com/post/72910908762/conceptual-difference-between-mocker... is an insightful post on that.

Within a project I would say no problem at all. Within a test, mh, depends how much it improves readability.

And this improves it a lot.

I'd say we should just commit it, want to continue working on #2528370: Simplify block caching and allow to cache the whole page, including access checks but kind of waiting for this to land as it will conflict a lot with the unit test changes that I will have to do there.

Too bad that tim is on vacation.

Wow, is that week already over? :)

Thanks, no problem, didn't have time anyway to work on it :)