JobItemForm::validateTags() is broken. [#2538534]

Problem/Motivation

When I review a translation and want to validate the HTML tags, I get an exception about preg_match_all() expecting a string as the second argument. In some cases it gets an array where the string is hidden inside the key value.

Proposed resolution

If the variable is not a string, try and extract the string from the array and pass it to preg_match_all() as before.

Remaining tasks

Review patch, commit.

User interface changes

None

API changes

None

Data model changes

None

Comment	File	Size	Author
#2	interdiff_0-2.txt	859 bytes	LKS90
#2	2538534-2.patch	668 bytes	LKS90
	jobitemform_validate_XXXXXXXXXXX_0.patch	674 bytes	LKS90

Comments

Comment #1

miro_dietiker

Switzerland

commented 23 July 2015 at 22:52

Status:

Needs review

» Needs work

+++ b/src/Form/JobItemForm.php
@@ -486,6 +486,12 @@ class JobItemForm extends TmgmtFormBase {
+      !isset($source['value']) ?: $source = $source['value'];
...
+      !isset($translation['value']) ?: $translation = $translation['value'];

Nooooo... A ternary operator is not intended as a replacement for a regular if condition.

It should be only used for a lvalue assignment.
a = b ? c : d;

In all other cases, please write ifs such as:

+    if (!is_string($source) && isset($source['value'])) {
+      $source = $source['value'];
+    };
+    if (!is_string($translation) && isset($translation['value'])) {
+      $translation = $translation['value'];
+    }

But i think we should even check for is_array instead of !is_string.