No idea why but couple of files have usage of some global vars that are not defined and then PHP is giving warnings like

Notice: Undefined index: theme_key in _bootstrap_process_theme_registry() (line 224 of themes/bootstrap/includes/registry.inc).

or

Notice: Undefined index: theme_path in _bootstrap_process_theme_registry() (line 242 of themes/bootstrap/includes/registry.inc).

This files are bootstrap.drush.inc, common.inc and registry.inc. I understand that drush part is waiting probably D7 version first to be done, but why globals are used in other two files, and are never set is not clear to me?

CommentFileSizeAuthor
#4 remove-globals-usage-2536656-4.patch1.57 KBs_leu
#3 remove-globals-usage-2536656-3.patch746 bytess_leu

Comments

markhalliwell’s picture

markhalliwell
Primary language English
commented

That is because 8.x is not actually stable (as stated on the project page). It is a port from the 7.x branch (where D7 uses globals). 7.x is currently HEAD (master) code.... not 8.x.

pivica’s picture

pivica commented

@markcarver got it, do you want me to try create a patch for this $GLOBALS or is it better not to touch them for now?

s_leu’s picture

s_leu commented
Status: Active » Needs review
StatusFileSize
new remove-globals-usage-2536656-3.patch746 bytes

Here's a patch against current 8.x-3.x to fix this.

s_leu’s picture

s_leu commented
StatusFileSize
new remove-globals-usage-2536656-4.patch1.57 KB

Last patch was incomplete, here's one that replaces all usages of $GLOBALS with the corresponding API calls.

s_leu’s picture

s_leu commented

  • neardark committed 4c6c82b on 8.x-3.x authored by s_leu 
    Issue #2536656 by s_leu: Using $GLOBALS in code
neardark’s picture

neardark commented
Status: Needs review » Fixed

Went ahead and merged this one in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.