here's the current state of my work on this module, now together with taxonomy_menu, custom pagers and views our image gallery works as 'expected'. Main changes:
- addition of a 'hack' to fix utf8 characters in file names (move all files to a path utf8encode()d)
- support for file transliteration with the transliteration module
- freetagging mode (default tags extracted from file path), with selection of appropiate vocabulary
- hierarchical taxonomy mode, additionally sets the terms hierarchical relations to resemble the path structure
- batch processing: each image is stored in a db table and then the images are imported one by one so theoretically you should be able to add hundreds of them at a time (only tested with 50 yet)
this is release candidate status, i.e. i developed with care and it works but it has not been widely tested. However i tried to make it fairly robust.. should solve a lot of the issues people hit during the last three years (!! *g)...

CommentFileSizeAuthor
#20 image_import-D5-modded.tar_.gz6.68 KBeMPee584
#18 image_import_253631.patch18.99 KBdrewish
#13 image_import-batch-taxonomy-tree.zip7.05 KBeMPee584
#1 image_import_5_overhauled.patch25.25 KBeMPee584
image_import_5_overhauled.patch24.99 KBeMPee584

Comments

eMPee584’s picture

eMPee584 commented
StatusFileSize
new image_import_5_overhauled.patch25.25 KB

w0Ot!! just imported 866 images in one go. some more polishments. wow this was a heavy weight.

drewish’s picture

drewish commented
Version: 5.x-2.x-dev » 6.x-1.x-dev
Status: Needs review » Needs work

we'll need to break up the parts of this that can be put into 6.x and those that are 5.x specific (i'm thinking of the batch portions). i'd also be into providing support for the transliterate module but it'd be better if that could be broken out into it's own issue.

eMPee584’s picture

eMPee584 commented

well ok haven't looked into the batch api yet, will do so in the next few days.. anything about the code you dislike? the .utf8fixed directory and recursive mkdir / rmdir stuff might look a bit dodgy?!

druvision’s picture

druvision commented

Seems great! Hope to test it soon under my Drupal6 installation.

For the meanwhile is a confusion between this sub-module (image_import) and the separate Drupal 4.6 image_import module - the project still exists and the features seems great.

Shall we merge the two? use the project page? Or at least add a note that image_import is now a part of the image module?

Amnon
-
Professional: Drupal Israel | Drupal Development & Consulting | Eco-Healing
Personal: Hitech Dolphin: Regain Simple Joy :)

druvision’s picture

druvision commented

The patch succeeds on Drupal5 version. On Drupal 6, only 7 of 10 hunks succeed.

Running it, I get an error that 'No image files were imported'.

druvision’s picture

druvision commented

Amazing interface. The above mentioned issue was solved. It works with the latest drupal5 version of image.module.

Usage tips:

1. You must select images to be imported before the import operation.
2. You must select the import method .

- otherwise no images are imported

druvision’s picture

druvision commented

When I go to the module's settings page and try to de-select the transliteration option, I get the following errors:


Warning: Table 'system' was not locked with LOCK TABLES query: SELECT * FROM system WHERE type = 'theme' in .../includes/database.mysql.inc on line 172

Warning: Table 'watchdog' was not locked with LOCK TABLES query: INSERT INTO watchdog (uid, type, message, severity, link, location, referer, hostname, timestamp) VALUES (1, 'php', '<em>Duplicate entry &amp;#039;image_import_remove_empty_directories_after_impo&amp;#039; for key 1\nquery: INSERT INTO variable (name, value) VALUES (&amp;#039;image_import_remove_empty_directories_after_import&amp;#039;, &amp;#039;i:1;&amp;#039;)</em> on file <em>../includes/database.mysql.inc</em> בשורה <em>172</em>.', 2, '', 'http://www.example.com/admin/settings/image_import', 'http://www.example.com/admin/settings/image_import', '89.138.171.206', 1210571170) in .../includes/database.mysql.inc on line 172
druvision’s picture

druvision commented

Is it better to take over the current image_import module page? This may provide for better issue tracking. If you want to, you can ask drupal's webmasters for help. Killes helped me to do it the last time.

eMPee584’s picture

eMPee584 commented

eehh, not sure how to proceed. ideally i thought drewish would grant me cvs access to the image module directory so image_import could live on in the contrib directory of it. I don't think the separate image_import page should be reopened as this module has lived as contrib in the image module since 5.x ....
about the issues with port to v6.x, i'll be looking into that in the next few days.
and levavie that error message you brought up does not look like it is caused by this module?!

yesct’s picture

yesct commented

think these patches will work with the keep tree (subdirectories as subgalleries) patch http://drupal.org/node/225014 ?

yesct’s picture

yesct commented

still wondering the same q.... :) cathy

wildlettuce’s picture

wildlettuce commented

This is just what I have been looking for!

Ok, total newbie question. What am I supposed to do with this patch? Do I add the script to image_import.install, do I replace image_import.install with this script, do I save the script as a separate .patch file? Is the script fine the way it is or do I need to change some aspect of it?

Thanks for taking the time to help a beginner - and remember to speak slowly and clearly. ;)

eMPee584’s picture

eMPee584 commented
StatusFileSize
new image_import-batch-taxonomy-tree.zip7.05 KB

wildlettuce: sorry to reply as late but if you're still interested in this functionality read http://drupal.org/node/60108 for instructions on how to apply patches... if you are on windows, don't have shell access to the server and no clue how to open a command prompt, i have attached the files, just extract, upload and run upload.php, visit the image_import settings page to review the options. You can then create a folder hierarchy in the image import directoy (usually files/images/import) and if you choose the correspondent option, each image will be tagged according to the names of the subfolders. Also, this includes kind of its own batch implementation so that you can import hundreds of images without timeout.

oh and regarding #7: that error occurred because you somehow canceled submitting the settings page then resubmitted it or so, so nothing to do with this patch.

Drewish: can we not possibly submit this to the 5.x-dev branch? it's a bit late anyways but...

Anonymous’s picture

Anonymous (not verified) commented

I'd like to encourage any help that image import can get. I've been uploading everything to Flickr, and then bringing them in through Embeded media batches.
Not ideal.
Thanks for your work on this.

Best,

Jonah Sharkey
Studio Phototrope

drewish’s picture

drewish commented

i'm super short on time so unless there's a clear patch that's focused on a single issue i'm not going to have time to review it.

drewish’s picture

drewish commented

As for update image_import in D6 i've overhauled audio_import (they've swapped code back and forth a few times) and it'd be a great source for updated batch api code: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/audio/contr...

eMPee584’s picture

eMPee584 commented

the only part of this patch that would make sense to be ported to D6 is the hierarchical taxonomy term extraction.. but more important for D5 users is definitely the implementation of a private batch processing that allows import of hundreds of images without timeout. i don't have much time to further work on this but the code posted seems to work without problems..

drewish’s picture

drewish commented
StatusFileSize
new image_import_253631.patch18.99 KB

sorry to ignore this for so long. i ended up i pulling in the updated audio_import module which uses the batch api. going to go ahead and commit this since the code is pretty well tested over in audio.

leaving the issue as CNW so we can see what of the original is applicable now.

domineaux’s picture

domineaux commented

After reading this thread I'm not sure if it works or not?

If it is working, how do you apply it?

I need to import over 2,000 photos onto 1 site and have them usable by a gallery software.

The photos I upload need to be available to the website via taxonomy, this is a problem for many gallery.

I have used the expose4 flash gallery, which is nothing buy an XML you basically accesss with an iframe type module.

The expose4 has a local application for building galleries, which can be somewhat taxonomy related.

It does work. The flash interface is cute, but confusing for users.

There are a few issues with the expose4 as well.

The dev no longer supports it or maybe I should say... is absent.

I started using it several years ago on Joomla, and eventually found a way to get it into Drupal.

Uploading 2,000+ photos is a waste of a good day.

The photos I am uploading are large sized, because the site owner uses his website as viewing tool.

Viewing them on a large 46" screen HDTV, is the problem.

You have to have large very high qualilty photos for quality viewing on a HDTV x 1080i

This of course slows down the rendering of the images, but I plan to build a local server and put the website on it.

This way, he still has the same content as his website, but the photos will render much faster and consistently.

Anyway, I've said a lot. If you've read this and have any suggestions. I'd sure be pleased to read them.

Thanks

eMPee584’s picture

eMPee584 commented
StatusFileSize
new image_import-D5-modded.tar_.gz6.68 KB

Well for you guys who don't know what to do with patches and who still run Drupal 5 and want to import a large number of images, here is my current state of the module; be sure to run the update script after copying this and then you can even put a hierarchical sorted set of images which will be tagged according to the subfolders they're in.

drewish’s picture

drewish commented
Title: PATCH: major overhauling of image_import module » Major overhauling of image_import module

How about a patch rather than a zip?

eMPee584’s picture

eMPee584 commented

well i posted the patch before didn't i?
dont think i have made any changes since then.

drewish’s picture

drewish commented

so the one from #1 is the same as the two patched version since then?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Closed (won't fix)

Please separate this patch into atomic changes. Users are unable to test otherwise. Also, please do not submit compressed archives to drupal.org (at all).

@drewish: Feel free to re-open this issue.

domineaux’s picture

domineaux commented

I am using 6x and I do need to get a fix on this.

If you have already done it... a link would sure help.

drewish’s picture

drewish commented

domineaux, update and see what's not there that you need from this patch.

basicmagic.net’s picture

basicmagic.net commented

subscribe