Hi,
I found a very small bugs on metatag_mobile submodule. If is inserted multiple values in the viewport filed (ex.: width=device-width, initial-scale=1, minimal-ui), every single value is splitted by comma and created different meta viewport (in this expla create 3 meta, one per string seprate by coma). At attachment you can see an image with 3 different meta.
I haven't study much more metatag module, but in metatag_mobile.metatag.inc i find the tag viewport is set to multiple: switch this to FALSE it seems that the meta in inserted correcty (one with all params).

Nice work, after all, for this module!
:)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna’s picture

Version: 7.x-1.6 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
623 bytes

Oh... yeah... bummer. The problem is that there can be multiple Viewport meta tags, and the standard separator is a comma, because that's what the Token module uses as a divider when a value has multiple items.

So what if the viewport only allowed one item?

DamienMcKenna’s picture

Status: Needs review » Fixed

Committed.

  • DamienMcKenna committed 0b03664 on 7.x-1.x
    Issue #2535178 by DamienMcKenna: 'multiple' option on Viewport causes...
DamienMcKenna’s picture

FYI this has been released in the new v7.x-1.7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.