Problem/Motivation

The problem was originally described in #2508830: Various UI problem with autocomplete select control.

How to reproduce (from the original report)

Have a clean Drupal core installation with entity_embed button enabled for full html format and bunch of nodes generated with devel generate. Tested in Chrome and FF and it both browsers problems are the same.

Click on the first entity embed button.

autocomplete suggestions clipped

Expected behavior

Obviously the suggestions container should flow out of the modal container and all suggestions should be visible.

Actual behavior

The suggestions of the autocomplete field are clipped by the modal container as it has a CSS definition containing "overflow: hidden" and users can not see all suggestions nor can they scroll them.

Further information

This is not an entity_embed specific issue, but it happens in all modals that contain an autocomplete widget.
JQuery UI had this problem too but it was fixed:

Dialog: Selectmenu/autocomplete in dialog window is cut off. So jQuery 1.12.0 release removed overflow hidden from dialog control because of the same problem we have now.

But then #2423781: Firefox crash using a modal: Firefox crash using a modal reintroduced overflow hidden in seven because of some weird FF problem on OS X when using modals.

Proposed resolution

Remove "overflow: hidden" from seven's CSS. I'm aware that this will re-introduce the problem, which was fixed #2423781: Firefox crash using a modal. But the problem with the autocomplete suggestions is sure more severe than that OS X and FF specific bug as it happens in multiple browsers and multiple Os'.

Remaining tasks

CommentFileSizeAuthor
#5 revert-2423781.patch539 bytesdroplet

Comments

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

That overflow problem caused a complete browser crash. That is a significantly worse problem than the sixth+ results of autocomplete getting clipped.

What is needed is a solution, not trading one problem for another.

nod_’s picture

nod_
Primary language French
Location Lille
commented

is the crash still happening on mac? don't have one, can't test.

droplet’s picture

droplet commented

I revert #2423781: Firefox crash using a modal and test in both Mac & Windows Firefox 39 and can't see any problems.

nod_’s picture

nod_
Primary language French
Location Lille
commented

All right, let's revert it then.

droplet’s picture

droplet commented
Status: Active » Needs review
StatusFileSize
new revert-2423781.patch539 bytes

No responses from #2423781: Firefox crash using a modal report and reviewers. Let's revert it. Let it break if it will crash the browsers and collect more meaningful debug logs during development stage.

yannickoo’s picture

yannickoo
Location Berlin
commented
Status: Needs review » Reviewed & tested by the community

Looks fine :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

I can confirm that I don't see the problem anymore. I hope everyone is updating firefox :)

Committed 6b4e86d and pushed to 8.0.x. Thanks!

  • alexpott committed 6b4e86d on 8.0.x 
    Issue #2535122 by droplet: Autocomplete suggestions in modal clipped due...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

This patch reverting #2423781: Firefox crash using a modal still freezes Firefox 38 Extended Support Release (ESR), which has an end of life of March, 2016.

It probably is not worth it to revert this patch as that pain will end early next year. But it does render the Views interface unusable for enterprise/corporate Firefox users who use ESR. Most likely a small portion of the community.

If that is the resolution for this freeze, then the minimum requirement for using the Drupal interface should note that Firefox 38 ESR is not supported.

droplet’s picture

droplet commented

Can you show me the exactly version and platform you used, I will test and provide a fix if i can.

https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/

And the steps to reproduce this problem.

Thanks.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

I tried the following to reproduce on simplytest.me:

  1. Create Article content (node/add/article)
  2. Go to Views (admin/structure/views)
  3. Create new view of type Content with Article content type selected. Unsorted.
  4. Add Filter
  5. Check the Body (value) field, freezes up for about 15 seconds
  6. Click the add and configure filter criteria, firefox locks between 30-60 seconds each time click on anything but the modal close button.

My results:

  • I did not reproduce the issue on Firefox 38.0.6 ESR GNU/Linux 3.18.17 (custom kernel) GCC 4.9.2 glibc 2.20
  • I was able to reproduce on Firefox 38.2.0 ESR Mac OS 10.10.4 2011 MacBook Pro
droplet’s picture

droplet commented

Confirmed.

- It's fixed in Firefox 39 from my testing.
- Only affected Mac OS.
- Turn off hardware acceleration in Firefox reduce the freeze time.
- Only freeze on FIRST click. For example, click checkbox -> freeze -> check another checkbox -> not freeze.

I will do further testing.