Closed (fixed)
Project:
Leaflet
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 Jul 2015 at 10:31 UTC
Updated:
30 Aug 2015 at 23:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
czigor commentedThe patch
Comment #2
pkej commentedHi,
I just installed the Leaflet library from the beta1 version. It doesn't pass the regex. I also tried writing a "greedier" and less exacting regexp:
version[=:] *['"]([\d+\.]+)[-\w]*['"]
This works with several more numerals in the version string, and cuts away everything from the hyphen. Furthermore it is agnostic with regards to the usage of " or '. It was changed between versions, it seems (though I can't verify, since all the download links for leaflet are dead, except for the beta version).
Comment #3
pkej commentedMy patch taking into account that the beta-version uses this format:
{version:'1.0-dev'}
Since the use of ' instead of " changed between versions the regexp is agnostic in this regard.
Comment #4
pkej commentedDarn, forgot to add leaflet to the beginning of the patch info :/
Comment #6
rdeboerApplied and committed the "pattern" part of this patch.
Thanks czigor and pkej.
Available now in 7.x-1.x-dev and 7.x-1.2 and later when released.
Rik