The 1.0-dev version has this version format:
{version:"1.0-dev"}
which does not fit our regexp.

Comments

czigor’s picture

Status: Active » Needs review
StatusFileSize
new935 bytes

The patch

  • allows : and = after the 'version' string
  • allows letters, underscore and dash inside the version string.
pkej’s picture

Hi,
I just installed the Leaflet library from the beta1 version. It doesn't pass the regex. I also tried writing a "greedier" and less exacting regexp:

version[=:] *['"]([\d+\.]+)[-\w]*['"]

This works with several more numerals in the version string, and cuts away everything from the hyphen. Furthermore it is agnostic with regards to the usage of " or '. It was changed between versions, it seems (though I can't verify, since all the download links for leaflet are dead, except for the beta version).

pkej’s picture

StatusFileSize
new3.79 KB

My patch taking into account that the beta-version uses this format:
{version:'1.0-dev'}

Since the use of ' instead of " changed between versions the regexp is agnostic in this regard.

pkej’s picture

Darn, forgot to add leaflet to the beginning of the patch info :/

  • RdeBoer committed dd5461d on 7.x-1.x authored by pkej
    Issue #2535054 by pkej, czigor: Leaflet library version 1.0-dev
    
rdeboer’s picture

Assigned: Unassigned » rdeboer
Status: Needs review » Fixed

Applied and committed the "pattern" part of this patch.
Thanks czigor and pkej.

Available now in 7.x-1.x-dev and 7.x-1.2 and later when released.

Rik

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.