Feeds Import Not Saving Geofield

Feeds has recently become stricter in handling empty values and calls indeed _field_filter_items() in order to avoid saving field data which the module considers to be empty. See for example these Feeds issues:
#2344827: Importing empty email field: email field is anyway created in the DB
#2499251: Link module: empty fields are rendered
#1107522-195: Framework for expected behavior when importing empty/blank values + text field fix

To fix this issue, Geofield should either adjust the empty check in geofield_field_is_empty() or make sure that geofield_set_target_simple() always sets $item['geom'].

I've the same issue.

I solved using alpha9 version of module.

The patch worked for me. Thanks.

I tried to apply this patch but it isn't working as I get errors like "patch unexpectedly ends in middle of line".

I'm using geofield 7.x-2.3 and feeds 7.x-2.0-beta1.
Might this be the problem?

Thanks!

Works with 7.x-2.3+0-dev, applies fine, thanks,put an end to hours of questions.

patch works! please commit!

+++ b/geofield.feeds.inc
@@ -143,6 +143,10 @@ function geofield_set_target_simple($source, $entity, $target, $values) {
+  if(!empty($entity->{$field_name}['und'][0]['lat']) && !empty($entity->{$field_name}['und'][0]['lon'])){
+    $entity->{$field_name}['und'][0] = geofield_compute_values($entity->{$field_name}['und'][0]);
+  }

This doesn't account for multi value fields. Probably should loop through the fields instead of hard coding a 0

LANGUAGE_NONE should be used instead of 'und'.

And nit on coding standards: spaces need before and after parentisies in the if statement. aka if () { not if(){

Ok maybe this would be a bit more robust?

And just to be make note, geofield_field_is_empty() is not getting input_format on the $item array so it just checks if 'geom' is empty and returns TRUE because it is not there.

So an alternative solution would just be maybe making that smarter? But I think this solution probably is the best so thank you @SeeWatson

I was tempted to fix the other uses of 'und' in that function but I held restraint, but we should all be using the language constant in all modules.

The formatting is from drupal's coding standards.

Control statements should have one space between the control keyword and opening parenthesis, to distinguish them from function calls.

https://www.drupal.org/coding-standards#controlstruct

Patch in #12 fixed this problem for me. Thanks!

Patch in #12 only solves the issue for latitude/longitude widgets. I'm facing the same problem using bounding boxes so I have added some more code to that patch but I think we may be missing many cases here. Someone more savvy should really take a look at this mess and find the correct solution.

Hello.
I had the same problem.
My modules:
Geofield 7.x-2.3
Feeds 7.x-2.0-beta1
Feeds import had not saving lat and lon.
Patch #17 fixed this problem.
Thanks!

Closing #2324927: Geofield Latitude/Longitude fields do not get imported with latest dev of Feeds as duplicate

Patch #17 fixed the problem.

I'm only using the long and lat fields at the moment but Patch #17 worked for me.

Patch #17 works.

With long and lat fields Patch #17 worked for me.

#17 works fine.
+1 for commit this.

Patch #17 fixed the problem.

#17 worked for me for simple lat/lon import. Thanks!

#17 worked for me as well. Now the lat/lon import is working.

#17 fixed the issue for me as well.

#17 worked to fix lat / long not getting imported

#17 works great! Thanks

#17 worked for me. Thank you.

Patch #17 worked for me too, thanks you.
Please commit !

+1 for commit =)

Feeds 7.x-2.0-beta2 is now ready for entity translation, hence the correct language code should be used instead of LANGUAGE_NONE. See also the change record.

the correct language code should be used instead of LANGUAGE_NONE

See also #2672788: Feeds integration: support mapping option "language".

+++ b/geofield.feeds.inc
@@ -142,6 +142,21 @@ function geofield_set_target_simple($source, $entity, $target, $values) {
+      $field[LANGUAGE_NONE][$delta]['geom'] = $field[LANGUAGE_NONE][$delta];

When using bounding box values, why is $field[LANGUAGE_NONE][$delta]['geom'] being set to $field[LANGUAGE_NONE][$delta]?

This issue is somewhat related because it provides a patch that alters the geofield_field_is_empty() function, specifically checking to see if ['geom'] is not set, and declaring the entire geofield empty if geom is empty.

#2672108: Don't save empty geometry WKT

EDIT: To be clear, they are two separate issues, and both need their own patch. I just wanted to point out that they deal with similar code. :-)

Attached is a new patch that uses geofield_compute_values() for both lat/lon and bounding box imports - ensuring that all the geofield data is filled in before saving.

I have tested this with lat/lon import, but not with bounding box import. @Pryrios: would you mind testing this patch, since you are importing bounding boxes?

@m.stenta

I have tested your patch and while I am not getting any errors it still doesn't seem to import.

I am building an importer for INSPIRE metadata so am quite busy on this at the moment. I will report back if I figure out what is going wrong.

@mikejuic3 - What parts are you trying to import, specifically? Latitude + longitude? Bounding box? WKT?

My patch is tested with Lat/lon, but I haven't tested with bounding box (although it should work the same).

@m.stenta The xml I am importing only contains bounding box coordinates. So I am importing bounding boxes. The feeds importer debugger shows that it is pulling in the BB coordinates but from there the import goes no further. I have tried both #38 and #17.

Cheers

A little more info, I think I have it more narrowed down:

$field[LANGUAGE_NONE][$delta] = geofield_compute_values($value, GEOFIELD_INPUT_BOUNDS);

Seems to return an empty array. $value contains my bounding box but GEOFIELD_INPUT_BOUNDS is not taking the bait. Watch this space.

I have it importing from bounds after some modifications. geofield_set_target_simple now looks like this:

function geofield_set_target_simple($source, $entity, $target, $values) {
  list($field_name, $sub_field) = explode(':', $target, 2);
  if (!is_array($values)) {
    $values = array($values);
  }

  $field = isset($entity->$field_name) ? $entity->$field_name : array('und' => array());
  $delta = 0;
  foreach ($values as $value) {
    $field['und'][$delta][$sub_field] = $value;
    $delta++;
  }
// Compute all the geofield values for each field value.
    foreach ($field[LANGUAGE_NONE] as $delta => $value) {
      if (!empty($value['lat']) && !empty($value['lon'])) {
        $field[LANGUAGE_NONE][$delta] = geofield_compute_values($value, GEOFIELD_INPUT_LAT_LON);
      }
      elseif (!empty($value['top']) && !empty($value['right']) && !empty($value['bottom']) && !empty($value['left'])) {
        $wkt_bounds_format = 'POLYGON((left bottom,right bottom,right top,left top,left bottom))';
        $wkt = strtr($wkt_bounds_format, array('top' => floatval($value['top']),
          'right' => floatval($value['right']),
          'bottom' => floatval($value['bottom']),
          'left' => floatval($value['left'])));
        $geometry = geoPHP::load($wkt);
        $field[LANGUAGE_NONE][$delta] = geofield_compute_values($geometry);
     }
    }

  $entity->$field_name = $field;
}

There were a couple of issues that needed to be sorted out and I am sure it can be done more cleanly than this.

Issues encountered:

1. geofield_compute_values uses geofield_geometry_from_values to get the geometry. The geometry from values function expects the array to be structured as: $raw_data['geom']['top']. I ripped the code, altered it and stuck it in the funtion above, although it should probably be sorted out in geofield_geometry_from_values
2. I was getting errors on floats that had minus values ie:-22.1234 so I wrapped them in floatval() which fixed that.
3. Finally I pass $geometry to geofield_compute_values() with no extra arguments and it processes the WKT into all the fields required for the import to work.

I can roll this into a patch but would like some input as to doing it a bit more efficiently.

Cheers.

Did anyone make Geofield CSV import work with Feeds 7.x-2.0-beta2? I have tried all of the patches listed here and none work. My configuration:

Feeds 7.x-2.0-beta2
Geofield 7.x-2.3

Mapping:

Lat -> Coordinates Latitude (field_coordinates:lat)
Lon -> Coordinates Longitude (field_coordinates:lon)

CSV file example:

Title|Language|Lat|Lon
Some title|en|20.00000|20.00000

All of the other fields get imported, but Geofield coordinates don't. I have also tried to make it work without the language set either in CSV or in the feed settings, but the result was the same.

Yes @1mundus #17 worked fine for me with exactly those requirements.

@mikejuic3 - Your logic makes sense, but I agree we should see if it is the most efficient. Your approach is essentially bypassing the bounding box entirely, by creating a polygon from the points, and then letting geofield_compute_values() fill in the rest.

So in essence, you're throwing out the second parameter of geofield_compute_values(), and therefore geofield_geometry_from_values() (the second parameter being $input_format in both). It works the same, but it feels to me like that piece of information (the input format) should be preserved.

So it sounds like the real issue here is: why is geofield_compute_values($value, GEOFIELD_INPUT_BOUNDS); returning an empty array as you said in comment #42?

Is it because $value needs to be formatted differently? Does it need to be a nested array within $value['geom']?

In other words, what if you use my patch from #38, but add the following line right above line 152:

$value = array('geom' => $value);

Does that make sense? Attached is a new patch to demonstrate what I mean. Could you test to see if this works?

@m.stenta

Apologies for taking so long to get back to you. I will test this out today or tomorrow and let you know. I can give a bit more detail then too.

I only tested patch #46 and I can verify it works. By it works, I mean that originally I was able to import nodes but not geofields. And now with the patch, I can import nodes and geofields.

Great work! Thanks for your contribution. [@m.stenta]

#46 worked for me. Thank you all for the work on these patches!

EDIT: It worked for LAT/LONG geofields on newly imported terms, but does not seem to update existing terms.

Hello,

#17 works for me with new nodes & existing nodes. I don't use the #46 because this patch seems to create a problem with the existing contents (#49).

Have you planned to commit this patch in the next version of Geofield? (important bug).

Thanks.

#17 I'm not quite sure that #17 updates the nodes, I was not able to update long and lat.

kansaj: My patch in #46 above can handle lat/lon. Please test that one and let us know if it works for you.

#52 I confirm that it handles correctly new nodes, but old ones are not updated.

@kansaj #46 worked for me, even for existing nodes, as soon as I temporarily checked "skip hash check" in the importer settings, for the first import after the patch had been applied.

Thanks @GaëlG, good point about the "skip hash check".

@kansaj, @kumkum29: can you please make sure that you have "skip hash check" unchecked when you are testing?

Feeds performs a hash on the data you are importing, and if it finds the same hash when you try to import the same data again, it will assume that nothing needs to be changed, so it won't update the nodes. For testing purposes you should have that hash check turned off, otherwise it will never make it to the code that we want to test.

Hi,
I could confirm the "skip hash check" worked as expected and updated the nodes.

Awesome, thanks for confirming @kansaj!

I think this is patch ready to be committed! Thanks everyone for helping to review!

#17 works for me.
Thanks.

@makbuk Thanks for the input - but the patch that we are currently reviewing is #46. Can you confirm that that one works for you as well?

Patch #46 works for me

Note: During import of latitude/longitude data, the correspondending field widget has to be "Latitude / Longitude".

Patch #46 works for me importing lat and lon one by one.

Patch #46 worked for me too. I used it for a leaflet widget field

Patch #46 worked for me - imports to POINT.

Another confirmation that the patch works.

#46 WORKED FOR ME

Need feeds support for D8.5
Could anyone familiar with these two module make a patch/ or patches？
I am constructing a site with info of a big bulk of locations and need to import those lat/lon data to their nodes and terms.
Sincerely wish you guys will offer support to solve this since I am not coder but only a builder.
Many thanks.

@sealionking Please open a new feature request for the 8.x-1.x branch. This one is specifically about a bug that exists in the current 7.x-2.x codebase, which has a proposed patch ready for review/commit.

#46 worked for me aswell - if that's anyhow relevant to point out. Thanks.

#46 bingo

#46 works

Issue is closed but patch still required. Dev branch only?