Hi,

the controller class uses some deprecated ways of calling watchdog and l()... cleanup here.

similar like: #2471661: Add and delete consumer link does not work

CommentFileSizeAuthor
#4 interdiff-25334412-3-4.diff.txt552 bytesfgm
#4 25334412-services-4.patch9.02 KBfgm
#3 25334412-services-3.patch8.62 KBfgm
#1 2534412-remove-old-methods.patch2.65 KBBlackice2999
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Blackice2999’s picture

Blackice2999 CreditAttribution: Blackice2999 commented
FileSize
2534412-remove-old-methods.patch2.65 KB
Blackice2999’s picture

Blackice2999 CreditAttribution: Blackice2999 commented
Status: Active » Needs review
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
FileSize
25334412-services-3.patch8.62 KB

Rerolled on current HEAD + some coding standards changes.

Node that Add works, but Delete does not: the "button" is displayed but doesn't trigger removal. When going to oauth/consumer/delete/(cid) manually, everything works normally, so this is not related to routing but to the form building.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
FileSize
25334412-services-4.patch9.02 KB
interdiff-25334412-3-4.diff.txt552 bytes

The format of the operations render element changed.

juampynr’s picture

juampynr CreditAttribution: juampynr as a volunteer commented
Status: Needs review » Closed (fixed)

These were fixed at #2331155: Unable to install, buildForm in Form classes incompatible with FormStateInterface::buildForm.

Closing.