[D7] Google Map Field Block

Hi nmeegama,
1. Please add the git link to your sandbox project front page.
2. We generally use define(), to create a constance which has to be used quite a lot times. But GOOGLE_MAP_FIELD_BLOCK_FIELD_PREFIX does not have any such heavy usage. So instead remove this define() and use gmfb_ directly.
3. In the function google_map_field_block_block_view($block_name = '') {... } you have a single case. You should have another default case, for the case when $block_name!=google_map_field_view_block
4. In your *.module file, you have the following function,

function google_map_field_block_content($block_name) {
....
$gmf_types = google_map_field_block_get_google_map_field_types();
...}

However the function google_map_field_block_get_google_map_field_types() is defined in google_map_field_block.utilities.inc, where you again call google_map_field_block_get_content_types_gmf_field_array() which in turn jumps again to *.module file.
It would be better if you keep the function google_map_field_block_get_google_map_field_types() {...} in *.module itself.

Also have a pareview test for your project and fix issues if any.

Hi,

You have about 48 errors as per Pareview.sh.

Also add you git clone URL:
http://git.drupal.org/sandbox/nmeegama/2074763.git

Automated Review

Manual Review

Individual user account

[Yes: Follows].

No duplication

No Duplication module.

Master Branch

[Yes: Follows]

Licensing

[No: Does not follow]

3rd party assets/code

[Yes: Follows ] .

README.txt/README.md

[Yes: Follows ] .

Code long/complex enough for review

[No: Does not follow]

Found "2 critical warnings, 7 normal warnings"

When there is no value in LAT & LONG fields, getting this Notice: Undefined index: und in google_map_field_block_content() (line 181 of C:\wamp\www\drupal7\sites\all\modules\google_map_field_block\google_map_field_block.module).

Secure code

[Yes: Meets the security requirements]

Coding style & Drupal API usage

[Yes: Follows]

any reason for this 3 review? =)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.