Follow-up to #2534058: [META] Usability of Responsive Image in Core
See point D
Problem/Motivation
Enable the Responsive Image module and change the formatter of the default image field of article to "responsive image". You won't be able to save the options because there are no responsive image style set,. Thus weird error appears
Proposed resolution
1. Change the error message in the form (see above) for "I'm am the site administrator" !!

2. Should we change the error message ? Because the term in link "Responsive Image style" was supposed to be another admin page, it is surprising to be move to below form.

3. Add a link to Responsive Image style just as per the simple Image formatter (see below)

Remaining tasks
- debate each point if needed, point 2 probably.
- implement patch
- review
User interface changes
- yes: that is the point
API changes
None
Data model changes
None
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | interdiff.txt | 1.1 KB | dom. |
| #7 | update_error_messages-2534074-7.patch | 3.65 KB | dom. |
| #2 | responsive-image.png | 14.04 KB | manishmore |
| #2 | update_error_messages-2534074-2.patch | 3.64 KB | manishmore |
Comments
Comment #1
dom. commentedComment #2
manishmore commentedBy this patch we can able to get user on add responsive image style page as per shown in issue image .
Comment #3
poornima.n commentedComment #4
dawehner.
Comment #5
rainbowarrayExtra spaces should be removed from this line.
This should probably be "Configure responsive image styles", right?
Is there a separate permission for administering responsive image styles?
This would be a nice UX improvement. Good find.
Comment #6
manishmore commentedHey mdrummond it's been fixed you can check into my patch.
Comment #7
dom. commentedThis new patch solves point 1, 2 and 3 of mdrummond review at #5.
Note concerning 2: I have added a capital letter to "Responsive" for consistancy.
This patch thus solves issue point 3 only.
Concerning issue point 1 and 2 it would mean override the default form validation. Is this something allowed to be done ? I can't find a Formatter that does so...
Comment #8
attiks commentedPatch looks good, 1 & 2 are default core behavior, so should not be changed in this issue, 2 is default as well, it links to the form element that caused the error.
Not sure if we need tests for this, personally I think it is fine without tests.
Comment #9
alexpottThis is now just a usability improvement which are permitted during beta. Committed cdbdc4d and pushed to 8.0.x. Thanks!
Comment #12
poornima.n commentedComment #13
poornima.n commentedComment #14
poornima.n commentedComment #15
poornima.n commented