Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for system migration into the system module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_system_cron
  • d6_system_file
  • d6_system_filter
  • d6_system_image
  • d6_system_image_gd
  • d6_system_logging
  • d6_system_maintenance
  • d6_system_performance
  • d6_system_rss
  • d6_system_site

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#7 interdiff.txt3.61 KBmikeryan
#7 move_module_specific-2534032-7.patch17.52 KBmikeryan
#2 move_module_specific-2534032-2.patch14.04 KBmikeryan

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Issue summary: View changes

Moved d6_url_alias to a separate issue for the path module - although the url_alias schema is installed by the system module, we only want to migrate aliases if the path module is enabled, so that's the proper place for that migration.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Active » Postponed
Related issues: +#2534158: MigrateFullDrupalTestBase must use dynamic test discovery
StatusFileSize
new move_module_specific-2534032-2.patch14.04 KB

Here's the patch, postponed on #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review

Unblocked.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks fine.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Reviewed & tested by the community » Needs work

Based on applying all the move patches, I believe the following should also move into the system module:

  • d6_date_formats.yml
  • MigrateDateFormatTest.php
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

Oh, and d6_menu.yml and other menu-related files...

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new move_module_specific-2534032-7.patch17.52 KB
new interdiff.txt3.61 KB
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Looks lovely and straightforward to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1743f6c and pushed to 8.0.x. Thanks!

  • alexpott committed 1743f6c on 8.0.x 
    Issue #2534032 by mikeryan: Move module-specific migration support into...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.