Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for search migration into the search module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_search_page
  • d6_search_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#13 interdiff.txt620 bytesmikeryan
#13 move_module_specific-2534024-13.patch4.68 KBmikeryan
#9 interdiff.txt660 bytesmikeryan
#9 move_module_specific-2534024-9.patch3.73 KBmikeryan
#2 move_module_specific-2534024-2.patch3.72 KBmikeryan
#1 move_module_specific-2534024-1.patch3.66 KBmikeryan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Assigned: Unassigned » mikeryan
Status: Active » Needs review
FileSize
move_module_specific-2534024-1.patch3.66 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs review » Needs work
FileSize
move_module_specific-2534024-2.patch3.72 KB

Move tests to Migrate directory. Leaving at needs work until MigrateDrupal6Test is fixed to accomodate the test movement.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Status: Needs work » Postponed

The last submitted patch, 1: move_module_specific-2534024-1.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan commented
Related issues: +#2534158: MigrateFullDrupalTestBase must use dynamic test discovery

Postponed on #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Following... once you un-postpone, I will be happy to RTBC. Patch is very straightforward and I trust that it's already been decided to do this for all modules. ;)

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Postponed » Needs review

Unblocked!

Status: Needs review » Needs work

The last submitted patch, 2: move_module_specific-2534024-2.patch, failed testing.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs work » Needs review
FileSize
move_module_specific-2534024-9.patch3.73 KB
interdiff.txt660 bytes

Fixed namespace.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
CreditAttribution: phenaproxima at Acquia commented
Status: Needs review » Reviewed & tested by the community

Me likey.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

+1

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Reviewed & tested by the community » Needs work

After applying all move patches, I believe EntitySearchPage.php still needs to move to the search module.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan at Acquia commented
Status: Needs work » Needs review
FileSize
move_module_specific-2534024-13.patch4.68 KB
interdiff.txt620 bytes
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

OK.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed

Committed 158ca15 and pushed to 8.0.x. Thanks!

  • alexpott committed 158ca15 on 8.0.x 
    Issue #2534024 by mikeryan: Move module-specific migration support into...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.