Problem/Motivation

Per #2533886: [meta] Move module-specific migration support into the particular modules supported, move support for locale migration into the locale module.

Proposed resolution

For the most part, this is a matter of moving files around and updating namespaces. Also, explicit destination module dependencies can be removed.

Migration templates to be moved:

  • d6_locale_settings

Remaining tasks

Submit a patch.

User interface changes

N/A

API changes

Namespaces of affected migration plugins will change.

Data model changes

N/A

CommentFileSizeAuthor
#4 interdiff-2534018-1-4.txt1.39 KBphenaproxima
#4 2534018-4.patch1.37 KBphenaproxima
#1 2534018-1.patch1.32 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Active » Needs review
StatusFileSize
new 2534018-1.patch1.32 KB

Status: Needs review » Needs work

The last submitted patch, 1: 2534018-1.patch, failed testing.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs work » Postponed

Blocked by #2534158: MigrateFullDrupalTestBase must use dynamic test discovery.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
StatusFileSize
new 2534018-4.patch1.37 KB
new interdiff-2534018-1-4.txt1.39 KB

Moved the test into the Drupal\locale\Tests\Migrate namespace.

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Postponed » Needs review

Unblocked.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 45202c4 and pushed to 8.0.x. Thanks!

  • alexpott committed 45202c4 on 8.0.x 
    Issue #2534018 by phenaproxima: Move module-specific migration support...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.